Fix incorrect deployment syntax #14384
Conversation
Calling .rollout() on a selector returns a RolloutManager but does not actually trigger a deployment. You must call .latest() on the RolloutManager. I opened an issue on this: openshift#14372 Don't know if there is a way to link it, sorry!
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @kkoller. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/XS
|
/ok-to-test @kkoller, thank you! @vikram-redhat, do you have a suggestion for a technical reviewer? This example is present back to 3.9, so it might be valid past 3.11. |
openshift-ci-robot
added
ok-to-test
|
@zhouying7780 are you able to confirm this? |
|
@kkoller, thank you! LGTM. |
|
/cherrypick enterprise-3.11 |
|
@vikram-redhat: new pull request created: #14411 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-3.10 |
|
@vikram-redhat: new pull request created: #14412 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-3.9 |
|
@vikram-redhat: new pull request created: #14413 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Calling .rollout() on a selector returns a RolloutManager but does not actually trigger a deployment. You must call .latest() on the RolloutManager. You can find the docs here, although it is an image so I can't link directly to it. It is the final section at the bottom of the page: https://github.com/openshift/jenkins-client-plugin
This commit fixes #14372