Skip to content

Conversation

@kalexand-rh
Copy link
Contributor

@kalexand-rh kalexand-rh added this to the Next Release milestone Feb 13, 2019
@kalexand-rh kalexand-rh self-assigned this Feb 13, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 13, 2019
ansible-playbook /usr/share/ansible/openshift-ansible/playbooks/redeploy-certificates.yml
----

. If you use xref:configuring-custom-certificates[named certificates]:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianlinliu, will you PTAL? (The other changes to the file are whitespace trimming.)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kalexand-rh I think we need to add some explanation here that the above steps are actually not working for now, so have to manually update the certificate parameters in master-config.yaml. Or else it looks like all of these steps are required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpei, I thought you did have to do both. Scott said that "The playbook will ensure that the certificate files are distributed to the hosts but won't update master-config.yaml." I interpreted that to mean that you had to run the playbook to distribute the certs and then separately add the parameters to the master-config.yaml file.

Is that right?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I forgot the step to distribute the certs, you're correct.

@openshift-docs-preview-bot

The preview will be availble shortly at:

@kalexand-rh
Copy link
Contributor Author

Thank you @gpei! Merging.

@kalexand-rh kalexand-rh merged commit bd0e893 into openshift:master Feb 19, 2019
@kalexand-rh kalexand-rh deleted the BZ1670732 branch February 19, 2019 12:54
@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-3.11

@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-3.10

@openshift-cherrypick-robot

@kalexand-rh: #13616 failed to apply on top of branch "enterprise-3.10":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	install_config/certificate_customization.adoc
Falling back to patching base and 3-way merge...
Auto-merging install_config/certificate_customization.adoc
CONFLICT (content): Merge conflict in install_config/certificate_customization.adoc
Patch failed at 0001 bug 1670732 need to update master-config.yaml for a cert change

Details

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #13659

Details

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-3.9 branch/enterprise-3.10 branch/enterprise-3.11 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants