-
Notifications
You must be signed in to change notification settings - Fork 1.9k
bug 1670732 need to update master-config.yaml for a cert change #13616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ansible-playbook /usr/share/ansible/openshift-ansible/playbooks/redeploy-certificates.yml | ||
| ---- | ||
|
|
||
| . If you use xref:configuring-custom-certificates[named certificates]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jianlinliu, will you PTAL? (The other changes to the file are whitespace trimming.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kalexand-rh I think we need to add some explanation here that the above steps are actually not working for now, so have to manually update the certificate parameters in master-config.yaml. Or else it looks like all of these steps are required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpei, I thought you did have to do both. Scott said that "The playbook will ensure that the certificate files are distributed to the hosts but won't update master-config.yaml." I interpreted that to mean that you had to run the playbook to distribute the certs and then separately add the parameters to the master-config.yaml file.
Is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, I forgot the step to distribute the certs, you're correct.
|
The preview will be availble shortly at:
|
|
Thank you @gpei! Merging. |
|
/cherrypick enterprise-3.11 |
|
/cherrypick enterprise-3.10 |
|
@kalexand-rh: #13616 failed to apply on top of branch "enterprise-3.10": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kalexand-rh: new pull request created: #13659 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From https://bugzilla.redhat.com/show_bug.cgi?id=1670732