-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Reveal openshift_master_manage_htpasswd variable in upgrade preparations #13586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@openshift/team-documentation PTAL, thanks. |
upgrading/automated_upgrades.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say:
If you manually manage the cluster's *_/etc/origin/master/htpasswd_* file, add
`openshift_master_manage_htpasswd=false` to your inventory file to prevent the
upgrade process from overwriting the *_htpasswd_* file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that, thanks!
kalexand-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd reword the change, but it LGTM
|
The preview will be availble shortly at:
|
|
@openshift/team-documentation, this PR is approved in the BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1666644#c8 If that is sufficient, I can merge this. Thanks. |
|
@jboxman, yup! After you make updates from peer review and QE review, you're good to merge and cherry-pick. |
|
Verified by QE[0]. |
|
/cherrypick enterprise-3.11 |
|
@jboxman: new pull request created: #13676 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-3.10 |
|
@jboxman: #13586 failed to apply on top of branch "enterprise-3.10": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The goal of this PR is to address the issue described in the bug linked above and described succinctly in this[0] solution. I'd appreciate suggestions on better ways to surface this information. I included it under 3. rather than 2. because it affects upgrading z-stream releases as well.
Thank you.
[0] https://access.redhat.com/solutions/3811271