Skip to content

bug 1656374 added notes for NetworkPolicy feature support #14352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheriff-rh merged 1 commit into from
Apr 11, 2019
Merged

bug 1656374 added notes for NetworkPolicy feature support #14352

sheriff-rh merged 1 commit into from
Apr 11, 2019

Conversation

@sheriff-rh
Copy link
Contributor

@sheriff-rh sheriff-rh commented Apr 4, 2019

Bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1656374

Requesting @openshift/team-documentation peer review please!

@sheriff-rh sheriff-rh added this to the Next Release milestone Apr 4, 2019
@sheriff-rh sheriff-rh self-assigned this Apr 4, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 4, 2019
jboxman
jboxman reviewed Apr 4, 2019
View reviewed changes
kalexand-rh
kalexand-rh reviewed Apr 5, 2019
View reviewed changes
kalexand-rh
kalexand-rh reviewed Apr 5, 2019
View reviewed changes
@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 5, 2019
@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 5, 2019

Corrections are in place. @bmeng PTAL.

@bmeng
Copy link

bmeng commented Apr 8, 2019

LGTM, thanks.

@sheriff-rh sheriff-rh merged commit ceb5403 into openshift:master Apr 11, 2019
@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 11, 2019

/cherrypick enterprise-3.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 11, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 11, 2019

@sheriff-rh: new pull request created: #14418

Details

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 11, 2019

/cherrypick enterprise-3.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 11, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 11, 2019

@sheriff-rh: new pull request created: #14424

Details

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 11, 2019

/cherrypick enterprise-3.9

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 11, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 11, 2019

@sheriff-rh: new pull request created: #14427

Details

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 11, 2019

/cherrypick enterprise-3.7

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 11, 2019

@sheriff-rh: #14352 failed to apply on top of branch "enterprise-3.7":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	admin_guide/managing_networking.adoc
M	install_config/configuring_sdn.adoc
Falling back to patching base and 3-way merge...
Auto-merging install_config/configuring_sdn.adoc
Auto-merging admin_guide/managing_networking.adoc
CONFLICT (content): Merge conflict in admin_guide/managing_networking.adoc
Patch failed at 0001 bug 1656374 added notes for NetworkPolicy feature support
Details

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sheriff-rh sheriff-rh mentioned this pull request Apr 11, 2019
Merged
@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 11, 2019

Looks like NetworkPolicy was tech preview only in 3.6, so I will not be cherry-picking to enterprise-3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

+1 more reviewer

@jboxman jboxman jboxman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sheriff-rh sheriff-rh

Labels

branch/enterprise-3.7 branch/enterprise-3.9 branch/enterprise-3.10 branch/enterprise-3.11 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@sheriff-rh @bmeng @openshift-cherrypick-robot @jboxman @kalexand-rh @openshift-ci-robot