Skip to content

Add missing registry examples to Ansible Broker Configuration #13926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bergerhoffer merged 2 commits into from
Apr 11, 2019
Merged

Add missing registry examples to Ansible Broker Configuration #13926

bergerhoffer merged 2 commits into from
Apr 11, 2019

Conversation

@nccurry
Copy link

@nccurry nccurry commented Mar 1, 2019

Fixes #13920

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 1, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 1, 2019

Hi @nccurry. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2019
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Mar 2, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2019
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Mar 2, 2019

@bergerhoffer - when you have a chance, PTAL.

bergerhoffer
bergerhoffer requested changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nccurry Thanks a lot for submitting these updates. Just a few things if you wouldn't mind updating.

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Mar 5, 2019

@chengzhang1016 Would you mind reviewing these updates as well? Or let me know if there's someone else who should provide QE review. Thanks!

@nccurry
Copy link
Author

nccurry commented Mar 5, 2019

Thanks for taking the time to look at this!
Requested modifications added.

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Mar 6, 2019

Thanks for the updates @nccurry! Once we get QE approval, I'll merge and cherry-pick this to enterprise-3.11.

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-3.11 labels Mar 6, 2019
@bergerhoffer bergerhoffer added this to the Next Release milestone Mar 6, 2019
@nccurry nccurry mentioned this pull request Mar 7, 2019
Closed
@kalexand-rh
Copy link
Contributor

kalexand-rh commented Apr 10, 2019

@chengzhang1016, will you PTAL?

@chengzhang1016
Copy link

chengzhang1016 commented Apr 10, 2019

@bergerhoffer @kalexand-rh Looks you are adding these changes in document of enterprise-3.11. We need one day to review and test, and will provide feedback by the end of tomorrow.

I and @zihantang-rh will review it.

@zihantang-rh
Copy link

zihantang-rh commented Apr 11, 2019

LGTM, thanks

@chengzhang1016
Copy link

chengzhang1016 commented Apr 11, 2019

The changes LGTM. Thx.

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Apr 11, 2019

Thanks @chengzhang1016 and @zihantang-rh!

Merging and cherry-picking to enterprise-3.11.

@bergerhoffer bergerhoffer merged commit fec0493 into openshift:master Apr 11, 2019
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Apr 11, 2019

/cherrypick enterprise-3.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 11, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 11, 2019

@bergerhoffer: new pull request created: #14425

Details

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer approved these changes

Assignees

No one assigned

Labels

branch/enterprise-3.11 ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

8 participants

@nccurry @openshift-ci-robot @vikram-redhat @bergerhoffer @kalexand-rh @chengzhang1016 @zihantang-rh @openshift-cherrypick-robot