Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1870189: Bump v3.4.14 #65

Merged
merged 106 commits into from
Mar 2, 2021

Conversation

hexfusion
Copy link

@hexfusion hexfusion commented Dec 15, 2020

crawshaw and others added 30 commits June 4, 2020 20:19
This makes it possible to run an etcd node for testing and development
without placing lots of load on the file system.

Fixes etcd-io#11930.

Signed-off-by: David Crawshaw <[email protected]>
modify file util.
Handle negative value input which currently gives a runtime error.
Handle the related panic and clarify doc.
When an etcd instance attempts to perform service discovery, if a
cluster size with negative value  is provided, the etcd instance
will panic without recovery because of
…-#11841-upstream-release-3.4

Automated cherry pick of etcd-io#11841
…-#11830-upstream-release-3.4

Automated cherry pick of etcd-io#11830
…-#11818-upstream-release-3.4

Automated cherry pick of etcd-io#11818
…-#11796-upstream-release-3.4

Automated cherry pick of etcd-io#11796
…-#11608-upstream-release-3.4

Automated cherry pick of etcd-io#11608
…-#11845-upstream-release-3.4

Automated cherry pick of etcd-io#11845
…-#11795-upstream-release-3.4

Automated cherry pick of etcd-io#11795
…-#11807-upstream-release-3.4

Automated cherry pick of etcd-io#11807
…-#11787-upstream-release-3.4

Automated cherry pick of etcd-io#11787
wal: add slice bound checks in decoder

CHANGELOG-3.5: add wal slice bound check
CHANGELOG-3.5: add "decodeRecord"

Signed-off-by: Gyuho Lee <[email protected]>
Currently, watch cancel requests are only sent to the server after a
message comes through on a watch where the client has cancelled. This
means that cancelled watches that don't receive any new messages are
never cancelled; they persist for the lifetime of the client stream.
This has negative connotations for locking applications where a watch
may observe a key which might never change again after cancellation,
leading to many accumulating watches on the server.

By cancelling proactively, in most cases we simply move the cancel
request to happen earlier, and additionally we solve the case where the
cancel request would never be sent.

Fixes etcd-io#9416
Heavy inspiration drawn from the solutions proposed there.
…r will check File Descriptor Requirements ,and count all fds in used. And recorded some logs when in used >= limit/5*4. Just recorded message. If fds was more than 10K,It's low performance due to FDUsage() works. So need to increase it.

see etcd-io#11969 for more detail.
…-#11798-upstream-release-3.4

Automated cherry pick of etcd-io#11798
…of-#12066-origin-release-3.4

Automated cherry pick of etcd-io#12066
…-#12060-upstream-release-3.4

Automated cherry pick of etcd-io#12060
…#11986-upstream-release-3.4

Automated cherry pick of etcd-io#11986
@hexfusion
Copy link
Author

marketplace..

/test e2e-aws-upgrade

@hexfusion
Copy link
Author

soak

/test all

@hexfusion
Copy link
Author

/retest

@hexfusion
Copy link
Author

/test e2e-aws
/test e2e-aws-upgrade

@hexfusion
Copy link
Author

soak

/test all

@hexfusion
Copy link
Author

/retest

1 similar comment
@hexfusion
Copy link
Author

/retest

@hexfusion hexfusion changed the base branch from openshift-4.7 to openshift-4.8 February 10, 2021 13:54
@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 10, 2021
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1870189, which is invalid:

  • expected Bugzilla bug 1870189 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1870189: Bump v3.4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 10, 2021
@hexfusion
Copy link
Author

/retest

@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1870189, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead
  • expected Bugzilla bug 1870189 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1870189: Bump v3.4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1870189, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead
  • expected Bugzilla bug 1870189 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1870189: Bump v3.4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1870189, which is invalid:

  • expected Bugzilla bug 1870189 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 25, 2021
@hexfusion
Copy link
Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2021
@hexfusion hexfusion added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Feb 25, 2021
@hexfusion
Copy link
Author

4.8 is open as 4.7 is GA group-lead approval should not be required I will look into why this is flagged. But I believe it is because the PR was open against 4.7 originally.

@hexfusion
Copy link
Author

/test all

@hexfusion
Copy link
Author

/test e2e-aws-upgrade

@hexfusion
Copy link
Author

I feel confident that this PR has been reasonably vetted and take responsibility for self-tagging but we need this to soak in CI.

@hexfusion hexfusion added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit c6ddbee into openshift:openshift-4.8 Mar 2, 2021
@openshift-ci-robot
Copy link

@hexfusion: All pull requests linked via external trackers have merged:

Bugzilla bug 1870189 has been moved to the MODIFIED state.

In response to this:

Bug 1870189: Bump v3.4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion deleted the bump_v3.4.14 branch March 2, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.