Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wal: fix panic when decoder not set #11807

Merged
merged 1 commit into from
Apr 23, 2020
Merged

wal: fix panic when decoder not set #11807

merged 1 commit into from
Apr 23, 2020

Conversation

spzala
Copy link
Member

@spzala spzala commented Apr 23, 2020

The Create function doc says a WAL is ready to read right after but it results in a panic. A returned WAL from call to Open is ready to read which is correctly mentioned in the Open func.

Handle the related panic and clarify doc.
@spzala spzala requested review from gyuho, xiang90 and mitake April 23, 2020 20:02
@spzala
Copy link
Member Author

spzala commented Apr 23, 2020

/cc @xiang90 @gyuho @mitake

@codecov-io
Copy link

Codecov Report

Merging #11807 into master will decrease coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11807      +/-   ##
==========================================
- Coverage   66.50%   65.99%   -0.51%     
==========================================
  Files         403      403              
  Lines       36981    36983       +2     
==========================================
- Hits        24595    24408     -187     
- Misses      10888    11070     +182     
- Partials     1498     1505       +7     
Impacted Files Coverage Δ
wal/wal.go 56.96% <100.00%> (+0.18%) ⬆️
client/members.go 65.32% <0.00%> (-20.17%) ⬇️
auth/store.go 52.38% <0.00%> (-19.25%) ⬇️
client/keys.go 78.39% <0.00%> (-13.07%) ⬇️
proxy/grpcproxy/register.go 72.50% <0.00%> (-10.00%) ⬇️
pkg/fileutil/purge.go 69.56% <0.00%> (-6.53%) ⬇️
clientv3/concurrency/mutex.go 61.64% <0.00%> (-5.48%) ⬇️
raft/tracker/inflights.go 91.83% <0.00%> (-4.09%) ⬇️
pkg/testutil/recorder.go 77.77% <0.00%> (-3.71%) ⬇️
etcdserver/api/v3rpc/member.go 87.09% <0.00%> (-3.23%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b650b...0d5c692. Read the comment docs.

@gyuho gyuho merged commit 69b70e8 into etcd-io:master Apr 23, 2020
@spzala
Copy link
Member Author

spzala commented Apr 23, 2020

Thanks @gyuho

gyuho added a commit that referenced this pull request Jun 22, 2020
…-upstream-release-3.4

Automated cherry pick of #11807
gyuho added a commit that referenced this pull request Jul 6, 2020
…-upstream-release-3.3

Automated cherry pick of #11807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants