Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdmain: fix shadow error #12066

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Conversation

tangcong
Copy link
Contributor

release-3.4 is failed to pass fmt/govet test.

etcdmain/gateway.go:139:11: declaration of "err" shadows declaration at line 96
The command "case "${TARGET}" in

https://travis-ci.com/github/etcd-io/etcd/jobs/352631586

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @tangcong
/cc @gyuho I guess good to get rid of it with a follow up cherry-pick

@tangcong
Copy link
Contributor Author

lgtm thanks @tangcong
/cc @gyuho I guess good to get rid of it with a follow up cherry-pick

thanks @spzala pr #12072 backports it to release-3.4.

gyuho added a commit that referenced this pull request Jun 25, 2020
…66-origin-release-3.4

Automated cherry pick of #12066
@gyuho gyuho merged commit 94bd71a into etcd-io:master Jun 25, 2020
@tangcong tangcong deleted the fix-fmt-shadow-err branch February 26, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants