Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: a new error code for the case of password auth against no passw… #11795

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Apr 19, 2020

…ord user

It will be useful for auditing logs and detecting authentication request with password against a no password user, which only accepts CN based authentication.

cc @xiang90 @gyuho @spzala

@mitake mitake changed the title auth: a new error code for the case of password auth against no passw… WIP auth: a new error code for the case of password auth against no passw… Apr 19, 2020
@mitake
Copy link
Contributor Author

mitake commented Apr 19, 2020

I'll add a test case for hitting the new path.

@codecov-io
Copy link

Codecov Report

Merging #11795 into master will decrease coverage by 0.51%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11795      +/-   ##
==========================================
- Coverage   66.22%   65.70%   -0.52%     
==========================================
  Files         403      403              
  Lines       36950    36950              
==========================================
- Hits        24469    24277     -192     
- Misses      10993    11155     +162     
- Partials     1488     1518      +30     
Impacted Files Coverage Δ
auth/store.go 59.55% <0.00%> (+6.60%) ⬆️
auth/options.go 53.75% <0.00%> (-38.75%) ⬇️
client/client.go 56.53% <0.00%> (-27.46%) ⬇️
client/keys.go 66.83% <0.00%> (-24.63%) ⬇️
auth/simple_token.go 65.54% <0.00%> (-23.53%) ⬇️
pkg/transport/timeout_conn.go 80.00% <0.00%> (-20.00%) ⬇️
etcdserver/api/v3rpc/lease.go 74.68% <0.00%> (-7.60%) ⬇️
pkg/netutil/netutil.go 61.47% <0.00%> (-7.38%) ⬇️
clientv3/concurrency/mutex.go 61.64% <0.00%> (-5.48%) ⬇️
clientv3/retry_interceptor.go 64.21% <0.00%> (-4.42%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0461b3f...94e7df0. Read the comment docs.

auth/store.go Outdated Show resolved Hide resolved
@mitake mitake changed the title WIP auth: a new error code for the case of password auth against no passw… auth: a new error code for the case of password auth against no passw… Apr 22, 2020
@spzala
Copy link
Member

spzala commented Apr 22, 2020

Thanks @mitake lgtm

@spzala spzala merged commit 43e8ffa into etcd-io:master Apr 22, 2020
@mitake mitake deleted the cn-auth-log branch April 22, 2020 22:54
gyuho added a commit that referenced this pull request Jun 22, 2020
…-upstream-release-3.4

Automated cherry pick of #11795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants