Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdmain: best effort detection of self pointing in tcp proxy #11845

Merged
merged 1 commit into from
May 31, 2020

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented May 4, 2020

Best effort approach to detect if the tcp gateway points to itself. Or the gateway might direct traffic to itself and cause an endless traffic loop.

@codecov-io
Copy link

Codecov Report

Merging #11845 into master will decrease coverage by 0.23%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11845      +/-   ##
==========================================
- Coverage   66.03%   65.79%   -0.24%     
==========================================
  Files         403      403              
  Lines       36993    37021      +28     
==========================================
- Hits        24428    24358      -70     
- Misses      11054    11148      +94     
- Partials     1511     1515       +4     
Impacted Files Coverage Δ
etcdmain/gateway.go 25.00% <0.00%> (-8.88%) ⬇️
auth/options.go 35.00% <0.00%> (-57.50%) ⬇️
clientv3/balancer/utils.go 53.84% <0.00%> (-46.16%) ⬇️
pkg/transport/timeout_conn.go 60.00% <0.00%> (-20.00%) ⬇️
auth/range_perm_cache.go 54.28% <0.00%> (-14.29%) ⬇️
pkg/netutil/netutil.go 61.47% <0.00%> (-6.56%) ⬇️
auth/store.go 52.38% <0.00%> (-6.47%) ⬇️
clientv3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
raft/tracker/inflights.go 91.83% <0.00%> (-4.09%) ⬇️
etcdserver/util.go 95.23% <0.00%> (-3.58%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb0a40...16810cd. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thx

@gyuho gyuho merged commit 09fcf55 into etcd-io:master May 31, 2020
gyuho added a commit that referenced this pull request Jun 22, 2020
…-upstream-release-3.4

Automated cherry pick of #11845
gyuho added a commit that referenced this pull request Jun 25, 2020
…-upstream-release-3.3

Automated cherry pick of #11845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants