-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/etcdenvvar: set periodical watch progress notification to 5s #548
pkg/etcdenvvar: set periodical watch progress notification to 5s #548
Conversation
Signed-off-by: Sam Batschelet <[email protected]>
/lgtm let's get up to the latest 3.4.z first, then re-test this. show significant smoothing and latency improvements on large clusters. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, hexfusion The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all cc @deads2k |
/hold upgrade apiserver downtime looks horrible[1] going to review that. /retest |
/hold cancel the upgrade API downtime is observed before this PR[1] in nightly so unrelated to this change. |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
While this ENV is currently marked experimental it has large positive performance impacts[1]. Upstream kep[2].
cc @deads2k
[1] https://github.com/kubernetes/kubernetes/pull/99021/files#diff-53f602f80b466ce021d5d5f8b14894997ccde64ae4d9b207296c3ca49978bdfbR555
[2] https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1904-efficient-watch-resumption