-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: note on the policy of insecure by default #11830
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spzala
reviewed
Apr 29, 2020
/cc @philips |
Codecov Report
@@ Coverage Diff @@
## master #11830 +/- ##
==========================================
+ Coverage 65.85% 66.14% +0.29%
==========================================
Files 403 403
Lines 36993 36993
==========================================
+ Hits 24362 24470 +108
+ Misses 11132 10993 -139
- Partials 1499 1530 +31
Continue to review full report at Codecov.
|
philips
reviewed
May 3, 2020
LGTM after 7 years -> since 2013 tweak. |
lgtm after test failure investigation |
Ok sounds good
…On Wed, May 6, 2020, 7:36 AM Hitoshi Mitake ***@***.***> wrote:
@philips <https://github.com/philips> The failed test case is
TestCtlV3Lock and it occasionally fails nondeterministically (e.g. #6464
<#6464>) because of the nature of
etcd lock. I think we don't need to open a new issue for it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11830 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAIGCG743JLR3MB6XFMCXDRQFYVPANCNFSM4MT3NQYA>
.
|
gyuho
added a commit
that referenced
this pull request
Jun 22, 2020
…-upstream-release-3.4 Automated cherry pick of #11830
gyuho
added a commit
that referenced
this pull request
Jun 25, 2020
…-upstream-release-3.3 Automated cherry pick of #11830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @xiang90 @spzala @gyuho