Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: note on the policy of insecure by default #11830

Merged
merged 1 commit into from
May 6, 2020

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Apr 29, 2020

@spzala
Copy link
Member

spzala commented Apr 29, 2020

/cc @philips

@codecov-io
Copy link

Codecov Report

Merging #11830 into master will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11830      +/-   ##
==========================================
+ Coverage   65.85%   66.14%   +0.29%     
==========================================
  Files         403      403              
  Lines       36993    36993              
==========================================
+ Hits        24362    24470     +108     
+ Misses      11132    10993     -139     
- Partials     1499     1530      +31     
Impacted Files Coverage Δ
auth/jwt.go 56.17% <0.00%> (-21.35%) ⬇️
pkg/transport/timeout_conn.go 60.00% <0.00%> (-20.00%) ⬇️
etcdserver/api/v3rpc/util.go 51.61% <0.00%> (-16.13%) ⬇️
client/keys.go 55.77% <0.00%> (-14.58%) ⬇️
auth/simple_token.go 79.83% <0.00%> (-9.25%) ⬇️
pkg/tlsutil/tlsutil.go 86.20% <0.00%> (-6.90%) ⬇️
clientv3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
proxy/grpcproxy/watcher.go 89.79% <0.00%> (-4.09%) ⬇️
etcdserver/api/v3rpc/watch.go 81.11% <0.00%> (-3.50%) ⬇️
etcdserver/api/v3rpc/member.go 87.09% <0.00%> (-3.23%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1044a8b...d231561. Read the comment docs.

@philips
Copy link
Contributor

philips commented May 4, 2020

LGTM after 7 years -> since 2013 tweak.

@spzala
Copy link
Member

spzala commented May 4, 2020

Thanks @philips
LGTM too after that change @mitake Thanks!

@philips
Copy link
Contributor

philips commented May 5, 2020

lgtm after test failure investigation

@mitake
Copy link
Contributor Author

mitake commented May 6, 2020

@philips The failed test case is TestCtlV3Lock and it occasionally fails nondeterministically (e.g. #6464) because of the nature of etcd lock. I think we don't need to open a new issue for it.

@philips
Copy link
Contributor

philips commented May 6, 2020 via email

@mitake mitake merged commit 035e1db into etcd-io:master May 6, 2020
@mitake mitake deleted the insecure-default branch May 6, 2020 14:54
gyuho added a commit that referenced this pull request Jun 22, 2020
…-upstream-release-3.4

Automated cherry pick of #11830
gyuho added a commit that referenced this pull request Jun 25, 2020
…-upstream-release-3.3

Automated cherry pick of #11830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants