Merge upstream 2021-03-30#139
Merged
openshift-merge-robot merged 37 commits intoopenshift:masterfrom Apr 6, 2021
Merged
Conversation
… options. Signed-off-by: s3rj1k <evasive.gyron@gmail.com>
After following the process described in our community documentation [1], there were no objections to adding Dmitry as an approver. [1] https://github.com/metal3-io/metal3-docs/tree/master/maintainers Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
add dmitry tantsur as approver
Upgrade CRD & Webhook to v1
The idrac BMCs have partiular handling of boot mode as configuration change requests which need to be honored only at power state changes as opposed to immediately, because this can conflict and over-write existing configuration jobs. While we shouldn't be in this state without more advanced bmc features being leveraged, it is best to use the vendor supported hardware type and interfaces for using redfish with their hardware. This boot interface defaults to using iPXE, as opposed to virtual media. A separate idrac specific redfish virtual media interface already existed in the baremetal-operator.
Use separate methods for setting update node options.
upgrade k8s/api to v0.2.1
…-ipxe Add idrac-redfish url type (continue)
Use the correct version of tools (from go.mod)
Add option to let Apache web server handle TLS on Ironic and Ironic-inspector sides Force the use of WSGI and remove the httpd container Remove the option to use reverse proxy for inspector Add option to use reverse proxy on ironic inspector
…oxy-nam Apache webserver handles TLS on Ironic
Bug: fix missing Inspecting state
Any host which lacks BMC details should reach the Unmanaged state regardless of whether it is externally provisioned or not. Currently in this case we encounter an error creating the ironic provisioner, because it expects BMC details to exist.
Decouple Unmanaged state from externallyProvisioned
Fix some lint errors
Instead of using `""` we will be using `no-raid`.
The support for RAID was considering RAIDInterface defaul value as `""`
to generate the clean steps, this is causing errors in vmedia
deployments with idrac because it uses `no-raid`:
"Node failed to start the first cleaning step. Error: node does not support
this clean step: {'interface': 'raid', 'step': 'delete_configuration'}"
Review registration log traces for Provisioner
Change default of RAIDInterface
Signed-off-by: s3rj1k <evasive.gyron@gmail.com>
Add a unit test for unsupported secure boot
The empty provisioner is a workaround for the fact that the ironic provisioner cannot handle instantiation when there are no BMC details available. The change cadeb28 that added it also had the effect of logging provisioner information on every reconcile when it was intended to be logged only once, at startup. Make it the ironic provisioner factory's responsibility to return an empty Provisioner at runtime when it cannot create an ironic Provisioner, and do only one-time startup configuration in main.go. Fixes metal3-io#819
Not every provisioner operation requires BMC access details, so only create them when needed. This allows us to reach the unmanaged state using the ironic provisioner when there are no BMC details specified. This also means that if the BMC details cannot be parsed correctly, rather than an error that causes constant requeues and is recorded only in the logs, we will record a registration failure that will be visible in the UI.
Now that the ironic provisioner only requires BMC details when registering (which does not occur in the unmanaged state), remove the empty provisioner workaround.
Eliminate need for "empty" provisioner
Pass go tests flags via env.
- Don't search by nodename if it has "~" in it - if POD_NAMESPACE is "" then use watchNamespace for the leader
Prepend the namespace to ironic nodenames to avoid conflicts
$ go mod tidy $ go mod vendor
openshift-ci-robot
added
the
approved
|
@honza would you mind rebasing this on the latest BMO again? Several important PRs landed yesterday (for example metal3-io#784 which is important to the iso based flow and there were several bugfixes) |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys, honza The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.