Skip to content

Add idrac-redfish url type (continue)#633

Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom
honza:juliakreger-idrac-redfish-ipxe
Mar 17, 2021
Merged

Add idrac-redfish url type (continue)#633
metal3-io-bot merged 1 commit intometal3-io:masterfrom
honza:juliakreger-idrac-redfish-ipxe

Conversation

@honza
Copy link
Copy Markdown
Member

@honza honza commented Sep 15, 2020

This is a rebased and gofmted #419

Original PR description below


The idrac BMCs have partiular handling of boot mode as configuration
change requests which need to be honored only at power state changes
as opposed to immediately, because this can conflict and over-write
existing configuration jobs.

While we shouldn't be in this state without more advanced bmc
features being leveraged, it is best to use the vendor supported
hardware type and interfaces for using redfish with their hardware.

This boot interface defaults to using iPXE, as opposed to virtual
media. A separate idrac specific redfish virtual media interface
already existed in the baremetal-operator.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 15, 2020
@dhellmann
Copy link
Copy Markdown
Member

/test-integration

@dhellmann
Copy link
Copy Markdown
Member

Does this imply that the "redfish" BMC type isn't actually useful? Should we remove it?

@dtantsur
Copy link
Copy Markdown
Member

The redfish one can be used for iLO and potentially other compliant vendor (supermicro seems to have at least some degree of compliance).

@dhellmann
Copy link
Copy Markdown
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2020
@dhellmann dhellmann requested a review from dtantsur September 16, 2020 19:53
@dhellmann
Copy link
Copy Markdown
Member

/cc @bfournie

@dhellmann
Copy link
Copy Markdown
Member

I would like to freeze go code changes for a few days to try to land #650 without having to rebase it, because rebasing will mean redoing the work from scratch.

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
@dhellmann
Copy link
Copy Markdown
Member

#655 has merged

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2020
@honza honza force-pushed the juliakreger-idrac-redfish-ipxe branch from 5197777 to e031f83 Compare October 1, 2020 19:02
@metal3-io-bot
Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2021
@dtantsur
Copy link
Copy Markdown
Member

/remove-lifecycle stale

Looks mostly good, although needs updating because of the secure boot changes. Could you rebase and fix the failing job?

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2021
The idrac BMCs have partiular handling of boot mode as configuration
change requests which need to be honored only at power state changes
as opposed to immediately, because this can conflict and over-write
existing configuration jobs.

While we shouldn't be in this state without more advanced bmc
features being leveraged, it is best to use the vendor supported
hardware type and interfaces for using redfish with their hardware.

This boot interface defaults to using iPXE, as opposed to virtual
media. A separate idrac specific redfish virtual media interface
already existed in the baremetal-operator.
@honza honza force-pushed the juliakreger-idrac-redfish-ipxe branch from e031f83 to c6dfc62 Compare March 15, 2021 16:32
@metal3-io-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, dtantsur, honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test-integration
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2021
@fmuyassarov
Copy link
Copy Markdown
Member

/test-integration

@metal3-io-bot metal3-io-bot merged commit b252310 into metal3-io:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants