Add idrac-redfish url type (continue)#633
Conversation
|
/test-integration |
|
Does this imply that the "redfish" BMC type isn't actually useful? Should we remove it? |
|
The redfish one can be used for iLO and potentially other compliant vendor (supermicro seems to have at least some degree of compliance). |
|
/approve |
|
/cc @bfournie |
|
I would like to freeze go code changes for a few days to try to land #650 without having to rebase it, because rebasing will mean redoing the work from scratch. /hold |
|
#655 has merged /hold cancel |
5197777 to
e031f83
Compare
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle stale Looks mostly good, although needs updating because of the secure boot changes. Could you rebase and fix the failing job? |
The idrac BMCs have partiular handling of boot mode as configuration change requests which need to be honored only at power state changes as opposed to immediately, because this can conflict and over-write existing configuration jobs. While we shouldn't be in this state without more advanced bmc features being leveraged, it is best to use the vendor supported hardware type and interfaces for using redfish with their hardware. This boot interface defaults to using iPXE, as opposed to virtual media. A separate idrac specific redfish virtual media interface already existed in the baremetal-operator.
e031f83 to
c6dfc62
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, dtantsur, honza The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test-integration |
This is a rebased and gofmted #419
Original PR description below
The idrac BMCs have partiular handling of boot mode as configuration
change requests which need to be honored only at power state changes
as opposed to immediately, because this can conflict and over-write
existing configuration jobs.
While we shouldn't be in this state without more advanced bmc
features being leveraged, it is best to use the vendor supported
hardware type and interfaces for using redfish with their hardware.
This boot interface defaults to using iPXE, as opposed to virtual
media. A separate idrac specific redfish virtual media interface
already existed in the baremetal-operator.