Cherry pick commits for namespacing ironic node names#140
Cherry pick commits for namespacing ironic node names#140asalkeld wants to merge 4 commits intoopenshift:masterfrom asalkeld:ironic-host-namespaced-downstream
Conversation
The empty provisioner is a workaround for the fact that the ironic provisioner cannot handle instantiation when there are no BMC details available. The change cadeb28 that added it also had the effect of logging provisioner information on every reconcile when it was intended to be logged only once, at startup. Make it the ironic provisioner factory's responsibility to return an empty Provisioner at runtime when it cannot create an ironic Provisioner, and do only one-time startup configuration in main.go. Fixes metal3-io#819
Not every provisioner operation requires BMC access details, so only create them when needed. This allows us to reach the unmanaged state using the ironic provisioner when there are no BMC details specified. This also means that if the BMC details cannot be parsed correctly, rather than an error that causes constant requeues and is recorded only in the logs, we will record a registration failure that will be visible in the UI.
Now that the ironic provisioner only requires BMC details when registering (which does not occur in the unmanaged state), remove the empty provisioner workaround.
- Don't search by nodename if it has "~" in it - if POD_NAMESPACE is "" then use watchNamespace for the leader
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asalkeld The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@asalkeld: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
We'll want whatever the outcome of metal3-io#842 is as well. Not specific to this PR, but is there a reason that we're cherry-picking stuff rather than just merging from upstream? Some sort of feature freeze I'm not aware of? |
I honestly just don't know what the default process is.. I assumed someone would do a periodic merge |
|
#139 contains all of these commits |
3 participants
This also pulls in Zane's small refactor so the code does not diverge too much.
/cc @zaneb