Skip to content

Fix some lint errors#823

Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom
elfosardo:fix-lint
Mar 23, 2021
Merged

Fix some lint errors#823
metal3-io-bot merged 1 commit intometal3-io:masterfrom
elfosardo:fix-lint

Conversation

@elfosardo
Copy link
Copy Markdown
Member

@elfosardo elfosardo commented Mar 22, 2021

No description provided.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 22, 2021
@elfosardo
Copy link
Copy Markdown
Member Author

elfosardo commented Mar 22, 2021

/test-integration

furkatgofurov7
furkatgofurov7 reviewed Mar 22, 2021
View reviewed changes
Comment thread apis/metal3.io/v1alpha1/baremetalhost_types.go Outdated
@dhellmann
Copy link
Copy Markdown
Member

dhellmann commented Mar 22, 2021

These all look OK. I wonder how the linter job we have didn't catch them. Do we need to change some settings?

@elfosardo
Copy link
Copy Markdown
Member Author

elfosardo commented Mar 23, 2021

/test-integration

@elfosardo
Copy link
Copy Markdown
Member Author

elfosardo commented Mar 23, 2021

These all look OK. I wonder how the linter job we have didn't catch them. Do we need to change some settings?

apparently we do, most of the linters in golangci-lint are disabled by default
I'll submit a PR with some basic options, we can choose if we want something more advanced later

@elfosardo elfosardo mentioned this pull request Mar 23, 2021
Merged
@hardys
Copy link
Copy Markdown
Member

hardys commented Mar 23, 2021

/approve

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Mar 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
dtantsur
dtantsur reviewed Mar 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread pkg/provisioner/ironic/ironic.go
return fmt.Sprintf("MAC address %s conflicts with existing node %s", e.Address, e.ExistingNode)
}

// NewMacAddressConflictError is a wrap for macAddressConflictError error
Copy link
Copy Markdown
Member

@dtantsur dtantsur Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem very informative, maybe we should improve it further.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2021
@metal3-io-bot metal3-io-bot merged commit ad72e4a into metal3-io:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtantsur dtantsur dtantsur left review comments

@furkatgofurov7 furkatgofurov7 Awaiting requested review from furkatgofurov7

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@elfosardo @dhellmann @hardys @metal3-io-bot @dtantsur @furkatgofurov7