Pass go tests flags via env.#833
Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom Mar 29, 2021
s3rj1k:TEST
Merged
Conversation
Signed-off-by: s3rj1k <evasive.gyron@gmail.com>
metal3-io-bot
added
the
size/S
Member
Author
|
/assign @russellb |
Member
Author
|
/test-integration |
Member
Author
|
@dhellmann Can you please also look at this, looks very trivial, but helps enormously, thanks. |
elfosardo
approved these changes
Mar 26, 2021
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, hardys, s3rj1k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make local development more convenient this PR add ability to pass go test flags via envars directly to unit-tests that are started in docker/podman instance.
So effectively one could use something like this:
Setting
failfastflag and removing verbose output is super-helpful on local dev environment when screen is small (less to scroll) and CPU/MEM resources are limited, so running all tests takes some time.(mainly this is scroll issue actually, but could also be helpful in other cases)
Signed-off-by: s3rj1k evasive.gyron@gmail.com