Use separate methods for setting update node options.#794
Use separate methods for setting update node options.#794metal3-io-bot merged 1 commit intometal3-io:masterfrom s3rj1k:deploy_interface
Conversation
|
Hi @s3rj1k. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dtantsur
left a comment
There was a problem hiding this comment.
/ok-to-test
/test-integration
… options. Signed-off-by: s3rj1k <evasive.gyron@gmail.com>
|
/test-integration |
|
@dtantsur please trigger /test-integration |
|
/test-integration |
|
@hardys Are we safe to merge? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, s3rj1k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dtantsur Thanks! |
This isolates options that are related to specific deploy_interface into separate methods making them a bit more readable.
This also would help with implementing new deploy_interface methods in the future.
Signed-off-by: s3rj1k evasive.gyron@gmail.com