Skip to content

Use separate methods for setting update node options.#794

Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom
s3rj1k:deploy_interface
Mar 16, 2021
Merged

Use separate methods for setting update node options.#794
metal3-io-bot merged 1 commit intometal3-io:masterfrom
s3rj1k:deploy_interface

Conversation

@s3rj1k
Copy link
Copy Markdown
Member

@s3rj1k s3rj1k commented Feb 14, 2021

This isolates options that are related to specific deploy_interface into separate methods making them a bit more readable.
This also would help with implementing new deploy_interface methods in the future.

Signed-off-by: s3rj1k evasive.gyron@gmail.com

@metal3-io-bot
Copy link
Copy Markdown
Contributor

Hi @s3rj1k. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2021
@s3rj1k
Copy link
Copy Markdown
Member Author

s3rj1k commented Feb 14, 2021

/assign @maelk

cc: @hardys

Copy link
Copy Markdown
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/test-integration

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2021
… options.

Signed-off-by: s3rj1k <evasive.gyron@gmail.com>
@s3rj1k
Copy link
Copy Markdown
Member Author

s3rj1k commented Feb 15, 2021

/test-integration

@s3rj1k
Copy link
Copy Markdown
Member Author

s3rj1k commented Feb 15, 2021

@dtantsur please trigger /test-integration

@s3rj1k
Copy link
Copy Markdown
Member Author

s3rj1k commented Feb 19, 2021

@dtantsur @maelk

@hardys
Copy link
Copy Markdown
Member

hardys commented Feb 19, 2021

/test-integration
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2021
@s3rj1k
Copy link
Copy Markdown
Member Author

s3rj1k commented Feb 26, 2021

@hardys Are we safe to merge?

@s3rj1k
Copy link
Copy Markdown
Member Author

s3rj1k commented Mar 15, 2021

@hardys @dtantsur ?

Copy link
Copy Markdown
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, s3rj1k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
@metal3-io-bot metal3-io-bot merged commit d123cc5 into metal3-io:master Mar 16, 2021
@s3rj1k
Copy link
Copy Markdown
Member Author

s3rj1k commented Mar 16, 2021

@dtantsur Thanks!

@s3rj1k s3rj1k deleted the deploy_interface branch March 16, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants