Use the correct version of tools (from go.mod)

[asalkeld]

Currently if you have a different version of the tools in GO_BIN something will fail.
I happened to have a slightly different version of controller-gen and kept getting manifest diffs.
By using the version specified in go.mod we avoid this annoyance.

[dhellmann]

Nice!

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asalkeld, dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dhellmann]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dhellmann]

/test-integration

[asalkeld]

/retest

[andfasano]

/test-integration

[fmuyassarov]

Integration test failed when running Install Ironic ansible task from metal3-dev-env. The task is running tools/deploy.sh script from BMO repo, which includes a Makefile target to create Kustomize binary. That line can probably be removed and all the referenced kustomize commands in deploy.sh also need to be changed accordingly.
CI output:

TASK [v1aX_integration_test : Install Ironic] **********************************
�[1;30mtask path: /home/****/metal3/vm-setup/roles/v1aX_integration_test/tasks/move.yml:65�[0m
�[0;31mfatal: [localhost]: FAILED! => {�[0m
�[0;31m    "changed": true,�[0m
�[0;31m    "cmd": "/home/****/tested_repo/tools/deploy.sh false true true true true",�[0m
�[0;31m    "delta": "0:00:00.405636",�[0m
�[0;31m    "end": "2021-03-12 11:10:09.423146",�[0m
�[0;31m    "invocation": {�[0m
�[0;31m        "module_args": {�[0m
�[0;31m            "_raw_params": "/home/****/tested_repo/tools/deploy.sh false true true true true",�[0m
�[0;31m            "_uses_shell": true,�[0m
�[0;31m            "argv": null,�[0m
�[0;31m            "chdir": null,�[0m
�[0;31m            "creates": null,�[0m
�[0;31m            "executable": null,�[0m
�[0;31m            "removes": null,�[0m
�[0;31m            "stdin": null,�[0m
�[0;31m            "stdin_add_newline": true,�[0m
�[0;31m            "strip_empty_ends": true,�[0m
�[0;31m            "warn": true�[0m
�[0;31m        }�[0m
�[0;31m    },�[0m
�[0;31m    "msg": "non-zero return code",�[0m
�[0;31m    "rc": 2,�[0m
�[0;31m    "start": "2021-03-12 11:10:09.017510",�[0m
�[0;31m    "stderr": "make[1]: *** No rule to make target 'bin/kustomize'.  Stop.",�[0m
�[0;31m    "stderr_lines": [�[0m
�[0;31m        "make[1]: *** No rule to make target 'bin/kustomize'.  Stop."�[0m
�[0;31m    ],�[0m
�[0;31m    "stdout": "~/tested_repo ~/metal3/vm-setup\nmake[1]: Entering directory '/home/****/tested_repo'\nmake[1]: Leaving directory '/home/****/tested_repo'",�[0m
�[0;31m    "stdout_lines": [�[0m
�[0;31m        "~/tested_repo ~/metal3/vm-setup",�[0m
�[0;31m        "make[1]: Entering directory '/home/****/tested_repo'",�[0m
�[0;31m        "make[1]: Leaving directory '/home/****/tested_repo'"�[0m
�[0;31m    ]�[0m
�[0;31m}�[0m

[asalkeld]

Integration test failed when running Install Ironic ansible task from metal3-dev-env. The task is running tools/deploy.sh script from BMO repo, which includes a Makefile target to create Kustomize binary. That line can probably be removed and all the referenced kustomize commands in deploy.sh also need to be changed accordingly.

Thanks for the pointer! I'll fix that right now.

[asalkeld]

/test-integration

[fmuyassarov]

/test-integration

[hardys]

/test-integration

[fmuyassarov]

Most probably the CI failure this time is not about the patch, but a common issue in the CI itself. The issue is being worked on right now, and update will be given soon. Related slack chat

[furkatgofurov7]

Most probably the CI failure this time is not about the patch, but a common issue in the CI itself. The issue is being worked on right now, and update will be given soon. Related slack chat

Thanks, hopefully, should be fine now.

/test-integration

[hardys]

/lgtm