Review PR for Ned and Xavier - #18
Closed
martynjames wants to merge 63 commits into
Closed
Conversation
…eded code is copied
Looking great - a couple of things that I've discovered when testing, I'm going to log some defects to help us track addressing them.
UI string review for google docs and calendar
no longer constrain height to 100% of parent - width constraint is sufficient
Documention on css changes and validation
Fixes for documentation on testing
…d code, and slight reordering for ease of reading
…e in which google doc was embedded
Contributor
There was a problem hiding this comment.
A minor nit, but it would be great to be in the habit of writing README.rst files instead of README.md files.
Feedback inspired changes
Added integration tests for studio views; Code clean-up;
Contributor
|
This PR is left for review purposes. Closed PR-21 and PR-22 and implemented changes that were suggested in the comments within those PRs. |
|
Posted a couple of answers/nits in answer to your comments on #23 but once addressed the changes made LGTM 👍 |
Code cleaning as a result of feedback
Code refactoring; Changed description for image alt text field
Contributor
|
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete review PR for xblock-google-drive