Bugfixes - #3
Conversation
|
Reset seems to work well 😃 A couple of display issues: ii) Spreadsheet document - rendering is constrained too narrowly: iii) Slides display too small in LMS: iv) Document too narrow in LMS: v) Spreadsheet too narrow in LMS: vi) Form too short in LMS: |
|
tests folder should be beneath google_drive folder instead of a sibling |
da8ccb3 to
27e3913
Compare
|
Squashed all commits to one. Also made changes so that only bugfix commits are included in this pull request. |
|
Good updates - but issues (iii) and (vi) still exist. Please address (iii) and (vi) and perform a rebase - the other 2 PRs have been integrated, and there are some merge conflicts Here a comparison: and
|
There was a problem hiding this comment.
I feel like this code should be executed only when the document is loaded - I think it should be within the jquery wrapped function below
There was a problem hiding this comment.
Problem is in the way XBlocks load javascript files in the first place. If I understood the way that works, that function will be assigned but not executed on the first load. It will be executed only when the reloading takes place. I struggled with that myself when I was making my very first XBlock. If you have any idea how we could go around that, I'm happy to change it.
There was a problem hiding this comment.
I moved it with no problem - I'll update this branch so that you can take a look
|
Regarding the slideshows and forms, I tried testing this with the slideshow you first added to the XBlock: <iframe src="https://docs.google.com/presentation/d/1B22AsMwG7jgE39vm1BuiJClir_JUz1q077cPEKJR2mI/embed?start=false&loop=false&delayms=3000" frameborder="0" width="960" height="569" allowfullscreen="true" mozallowfullscreen="true" webkitallowfullscreen="true"></iframe>Both slideshows and forms allow users to define the width and height of the embedded iframe explicitly. Perhaps you might try and change that on the Google Drive side and see if the changes take place and if that's a satisfactory solution. IMO, if user have option to specifically define the width and height on one side, we shouldn't try to affect that via css. |
62a00c9 to
b934fb4
Compare
|
The problem is the constraint of I've added some changes to this branch - @marjev please look and see if you like them - if so, please merge this PR. |
a38a1a7 to
e047237
Compare
e047237 to
a5be4e1
Compare
|
I also squashed some of your commits into one - some of them had interim merge commits with <<<<HEAD etc. markers for conflicts |
2 participants
Fixed input field for the calendar ID
Adjusted width and height of the images so that they don't overflow outside the XBlock div
Enabled reseting the value to default in studio modal