UI string review for google docs and calendar - #2
Merged
Conversation
Contributor
Author
|
also should tag Carol Tong and Marco; they don't appear to be in edx-solutions yet |
Contributor
Author
There was a problem hiding this comment.
It might be helpful to say something like "In your source Google calendar, open Settings and copy..."
Contributor
Author
|
@catong updated per comments. @martynjames can you confirm. Carol, I should know but am not sure how to build a sandbox with this xblock added. If we can get it merged and have an updated sandbox, we should have time to review then. |
|
Thanks @mhoeber - LGTM 👍 When merged, I'll rebuild the sandbox with the changes so that you can see them |
|
👍 |
mhoeber
force-pushed
the
markhoeber-studio-UI-review
branch
from
November 24, 2014 15:03
1621944 to
366b3c9
Compare
mhoeber
added a commit
that referenced
this pull request
Nov 24, 2014
UI string review for google docs and calendar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOC-1294