Adds google drive components to whitelist - #6903
Conversation
|
@chrisndodge, @mattdrayer - Can either of you take a look as a first review of this? |
There was a problem hiding this comment.
Just because I feel lIke I need to say something :) Would it be possible to include a bit more context here, perhaps with URL references as above?
|
Also, just in terms of the xblock-utils repo -- it might be nice to move this from edx-solutions to edx at some point, and possibly even into the XBlock repository vs. its own. Although this observation is outside of the scope/context of this PR. |
b1b0724 to
3912f6a
Compare
|
Thanks very much for addressing the feedback in openedx/xblock-google-drive#18 via openedx/xblock-google-drive#20 -- 👍 for me |
|
@nedbat - Hoping you can take a look at this PR - this is for integrating the google-drive xblock into edx. Sandbox Available at: pr6903.m.sandbox.edx.org |
3912f6a to
cb2b696
Compare
|
@antoviaque - you did a nice review pass on the google drive xblock toward the end of 2014 - any change you could look at this, and the xblock updates (openedx/xblock-google-drive#21). |
|
@martynjames I did a pass on that diff - a few comments but I am 👍 once they are addressed. |
|
@mhoeber This will be a new component in Open edX, and will need documentation. |
|
@martynjames For publicizing this new component, can you provide some screenshots and a blog post that we can use? It doesn't have to be a magnum opus, but enough to get the idea across in a short piece. |
|
@nedbat this was done for Saudi. Being merged into "birch doc" and edx.org this week I believe. you can see saudi doc version now: http://edx.readthedocs.org/projects/doroob-student-documentation/en/latest/SFD_google_docs.html |
|
@lamagnifica FYI |
|
There has been confusion related to multiple PRs. openedx/xblock-google-drive#18 is the current PR for review of the XBlock itself. |
e5a6795 to
6b4e328
Compare
|
@nedbat - Hoping you can give a thumbs up for this integration into OpenEdx |
There was a problem hiding this comment.
Xavier is running a review of this now, is it ready to be merged?
There was a problem hiding this comment.
Not sure - I'll let him answer (@antoviaque). He moved it into edx account (instead of edx-solutions).
There was a problem hiding this comment.
@martynjames @nedbat Our pending review is only with additional changes which aren't yet in master on that repository: openedx-unsupported/xblock-utils#5
For the review of the current master of xblock-utils, I assumed it was done as part of the google-drive code review since you had created openedx-unsupported/xblock-utils#6 ?
…drive and xblock-utils
4f7e187 to
b2b56d0
Compare
|
👍 |
Adds google drive components to whitelist
and imports xblock-google-drive and xblock-utils