Skip to content

Adds google drive components to whitelist - #6903

Merged
martynjames merged 1 commit into
masterfrom
mjames/SOL-200
Feb 25, 2015
Merged

Adds google drive components to whitelist#6903
martynjames merged 1 commit into
masterfrom
mjames/SOL-200

Conversation

@martynjames

Copy link
Copy Markdown

and imports xblock-google-drive and xblock-utils

@martynjames

Copy link
Copy Markdown
Author

@chrisndodge, @mattdrayer - Can either of you take a look as a first review of this?
It's a little complicated by the addition of xblock-utils (https://github.com/edx-solutions/xblock-utils) as well, but that was a suggested inclusion during the review cycles for the xblock-google-drive itself (https://github.com/edx-solutions/xblock-google-drive)

Comment thread cms/envs/common.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because I feel lIke I need to say something :) Would it be possible to include a bit more context here, perhaps with URL references as above?

@mattdrayer

Copy link
Copy Markdown
Contributor

Also, just in terms of the xblock-utils repo -- it might be nice to move this from edx-solutions to edx at some point, and possibly even into the XBlock repository vs. its own. Although this observation is outside of the scope/context of this PR.

@mattdrayer

Copy link
Copy Markdown
Contributor

Thanks very much for addressing the feedback in openedx/xblock-google-drive#18 via openedx/xblock-google-drive#20 -- 👍 for me

@martynjames

Copy link
Copy Markdown
Author

@nedbat - Hoping you can take a look at this PR - this is for integrating the google-drive xblock into edx.

Sandbox Available at: pr6903.m.sandbox.edx.org

@martynjames

Copy link
Copy Markdown
Author

@antoviaque - you did a nice review pass on the google drive xblock toward the end of 2014 - any change you could look at this, and the xblock updates (openedx/xblock-google-drive#21).

@antoviaque

Copy link
Copy Markdown
Contributor

@martynjames I did a pass on that diff - a few comments but I am 👍 once they are addressed.

@nedbat

nedbat commented Feb 17, 2015

Copy link
Copy Markdown
Contributor

@mhoeber This will be a new component in Open edX, and will need documentation.

@nedbat

nedbat commented Feb 17, 2015

Copy link
Copy Markdown
Contributor

@martynjames For publicizing this new component, can you provide some screenshots and a blog post that we can use? It doesn't have to be a magnum opus, but enough to get the idea across in a short piece.

@mhoeber

mhoeber commented Feb 17, 2015

Copy link
Copy Markdown
Contributor

@mhoeber

mhoeber commented Feb 17, 2015

Copy link
Copy Markdown
Contributor

@lamagnifica FYI

@smagoun

smagoun commented Feb 19, 2015

Copy link
Copy Markdown

There has been confusion related to multiple PRs. openedx/xblock-google-drive#18 is the current PR for review of the XBlock itself.

@martynjames

Copy link
Copy Markdown
Author

@nedbat - Hoping you can give a thumbs up for this integration into OpenEdx

Comment thread requirements/edx/github.txt Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xavier is running a review of this now, is it ready to be merged?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure - I'll let him answer (@antoviaque). He moved it into edx account (instead of edx-solutions).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martynjames @nedbat Our pending review is only with additional changes which aren't yet in master on that repository: openedx-unsupported/xblock-utils#5

For the review of the current master of xblock-utils, I assumed it was done as part of the google-drive code review since you had created openedx-unsupported/xblock-utils#6 ?

@nedbat

nedbat commented Feb 25, 2015

Copy link
Copy Markdown
Contributor

👍

martynjames pushed a commit that referenced this pull request Feb 25, 2015
Adds google drive components to whitelist
@martynjames
martynjames merged commit a44132e into master Feb 25, 2015
@martynjames
martynjames deleted the mjames/SOL-200 branch February 26, 2015 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants