Added integration tests for studio views; Code clean-up; - #23
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
Removed explicitly set default values.
There was a problem hiding this comment.
There are still a lot of values set in this file - are they all different from the defaults?
marjev
force-pushed
the
mjevtic/PR-21-review
branch
from
February 19, 2015 08:07
061f3b8 to
64c7b7a
Compare
marjev
added a commit
that referenced
this pull request
Feb 19, 2015
Added integration tests for studio views; Code clean-up;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@antoviaque Please review this. Regarding PR-21