Analytics - #4
Merged
Merged
Conversation
There was a problem hiding this comment.
Should be using self.runtime.publish from within XBlocks instead of eventtracking.tracker - this allows any XBlock runtime to report the event as it sees fit.
chrisndodge
force-pushed
the
mjevtic/analytics-emit-events
branch
from
December 2, 2014 10:43
4ec7d19 to
7e5218d
Compare
Contributor
Author
|
Changed commits so that only analytics stuff reside in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@martynjames
I added handlers that are called via AJAX calls when the iframe or image is loaded. I would like if someone from the analytics team take a peak at this too see if it works as expected.