Validation - #5
Merged
Merged
Conversation
chrisndodge
force-pushed
the
mjevtic/validation
branch
3 times, most recently
from
December 1, 2014 12:02
6a4f1e8 to
5366c0d
Compare
Contributor
Author
|
Calendar doesn't have to be validated since Google seems to have some internal logic that prevents us from getting Page Not Found result. Even when no ID is provided, Google returns a calendar. |
|
Contributor
Author
|
Should validation be ran only when the Save button is clicked? Right now, validation is ran each time a key is pressed while the focus is on text area, which would in worst case scenario spam the server with validation requests and might confuse the user when the text area gets colored in red before the editing is over. |
chrisndodge
force-pushed
the
mjevtic/validation
branch
2 times, most recently
from
December 2, 2014 11:23
0883a60 to
bd84e50
Compare
martynjames
force-pushed
the
mjevtic/validation
branch
from
December 2, 2014 19:52
dadbdd8 to
3cce68c
Compare
martynjames
pushed a commit
that referenced
this pull request
Dec 2, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes small issue that happens because documents and spreadsheets don't have width and height in their embed code
Validates whether the url of the Google file is valid (if it returns 200). Validation is on server side and I presumed that user won't edit or type the code in the text area, but will copy-paste it.