Skip to content

Validation - #5

Merged
martynjames merged 3 commits into
masterfrom
mjevtic/validation
Dec 2, 2014
Merged

Validation#5
martynjames merged 3 commits into
masterfrom
mjevtic/validation

Conversation

@marjev

@marjev marjev commented Dec 1, 2014

Copy link
Copy Markdown
Contributor
  1. Fixes small issue that happens because documents and spreadsheets don't have width and height in their embed code

  2. Validates whether the url of the Google file is valid (if it returns 200). Validation is on server side and I presumed that user won't edit or type the code in the text area, but will copy-paste it.

@chrisndodge
chrisndodge force-pushed the mjevtic/validation branch 3 times, most recently from 6a4f1e8 to 5366c0d Compare December 1, 2014 12:02
@marjev

marjev commented Dec 1, 2014

Copy link
Copy Markdown
Contributor Author

Calendar doesn't have to be validated since Google seems to have some internal logic that prevents us from getting Page Not Found result.

Even when no ID is provided, Google returns a calendar.

@martynjames

Copy link
Copy Markdown
  1. I think that we need to support a user editing the iframe code - although it is true that the main use case is the copy/paste action.
  2. I seem to get a blank screen if no calendar id is provided - I would have imagined google giving us an empty calendar for reference, but that does not appear to be what actually happens
  3. Seems to fix word processor documents and spreadsheets problems in previous PR - those fixes should really be applied to the original PR that broke them.
    These 3 PRs could either be:
    i) incorporated into 1 PR, or
    ii) more correctly separated - bugfixes in one, validation in another, event tracking in a third

@marjev

marjev commented Dec 2, 2014

Copy link
Copy Markdown
Contributor Author

Should validation be ran only when the Save button is clicked? Right now, validation is ran each time a key is pressed while the focus is on text area, which would in worst case scenario spam the server with validation requests and might confuse the user when the text area gets colored in red before the editing is over.

@marjev marjev changed the title Fixes for width and height & Validation Validation Dec 2, 2014
@chrisndodge
chrisndodge force-pushed the mjevtic/validation branch 2 times, most recently from 0883a60 to bd84e50 Compare December 2, 2014 11:23
martynjames pushed a commit that referenced this pull request Dec 2, 2014
@martynjames
martynjames merged commit 38c7535 into master Dec 2, 2014
@Agrendalath
Agrendalath deleted the mjevtic/validation branch February 18, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants