feat: Added Schedule and Details MFE page by ruzniaievdm · Pull Request #547 · openedx/frontend-app-authoring

ruzniaievdm · 2023-08-01T15:33:37Z

Description

Created a new page for Schedule and details
Added basic, credit, details, instructors, introducing, learning outcomes, license, pacing, requirements and schedule sections
Added WysiwygEditor
Fixed bugs
Added internet connection error

Please merge it after

frontend-lib-content-components PR
edx-platform PR

* feat: Create MFE page with base structure for schedule and details

* feat: Add Course schedule section to the MFE page * fix: after demo and resolve discussions * resolve discussions round 2

#12) * feat: Add default views for Course Details and Introduce Your Course sections * fix: resolve discussions

…ourse sections (#13)

* feat: Add Requirements and Licensing section * fix: add stateful button for saving advanced settings

fix: discussions on schedule and details page, hide cancel button, show success alert, internet connection

codecov · 2023-08-03T09:22:36Z

Codecov Report

Patch coverage: 82.54% and project coverage change: +1.83% 🎉

Comparison is base (9f4422d) 79.48% compared to head (9b97f87) 81.32%.
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   79.48%   81.32%   +1.83%     
==========================================
  Files         145      234      +89     
  Lines        2710     3812    +1102     
  Branches      636      873     +237     
==========================================
+ Hits         2154     3100     +946     
- Misses        526      675     +149     
- Partials       30       37       +7

Files Changed	Coverage Δ
src/CourseAuthoringRoutes.jsx	`100.00% <ø> (ø)`
src/index.jsx	`0.00% <ø> (ø)`
src/store.js	`100.00% <ø> (ø)`
src/studio-header/Header.jsx	`100.00% <ø> (ø)`
src/generic/course-upload-image/data/api.js	`25.00% <25.00%> (ø)`
src/schedule-and-details/data/thunks.js	`44.11% <44.11%> (ø)`
src/generic/WysiwygEditor.jsx	`51.72% <51.72%> (ø)`
src/schedule-and-details/license-section/hooks.jsx	`60.00% <60.00%> (ø)`
src/schedule-and-details/utils.js	`60.52% <60.52%> (ø)`
src/schedule-and-details/hooks.jsx	`64.00% <64.00%> (ø)`
... and 66 more

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* fix: console errors on schedule and details page * fix: schedule and details input border color * fix: initial state for wysiwyg fix: [2U-270] requirements section with disabled flags (#34) feat: 2u-237 add minHeigh prop to component

openedx-webhooks · 2023-08-03T16:25:58Z

Thanks for the pull request, @ruzniaievdm! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

KristinAoki · 2023-08-03T16:21:03Z

Depending on the page certain links should not show. For example, on the Schedule and details page the user should not see a link for the Schedule and details page

KristinAoki · 2023-08-03T16:36:21Z

+          <Hyperlink
+            destination={creativeCommonsAboutURL}
+            target="_blank"
+            showLaunchIcon={false}
+          >


Suggested change

<Hyperlink

destination={creativeCommonsAboutURL}

target="_blank"

showLaunchIcon={false}

>

I've removed it, but there should still be this link with comparing it to the legacy version

KristinAoki · 2023-08-04T15:12:44Z

+          />
+        ))}
+      </ul>
+      <Button iconBefore={AddIcon} variant="outline-success" onClick={handleAdd}>


Suggested change

<Button iconBefore={AddIcon} variant="outline-success" onClick={handleAdd}>

<Button iconBefore={AddIcon} variant="primary" onClick={handleAdd}>

As i understand, we have already approved style design. Do we really need to apply these changes?

You can skip these changes

Already added)

KristinAoki · 2023-08-04T15:13:12Z

+      <ul className="learning-outcomes-list">
+        {learningInfo.map(renderLearningOutcomeItem)}
+      </ul>
+      <Button iconBefore={AddIcon} variant="outline-success" onClick={handleAdd}>


Suggested change

<Button iconBefore={AddIcon} variant="outline-success" onClick={handleAdd}>

<Button iconBefore={AddIcon} variant="primary" onClick={handleAdd}>

KristinAoki · 2023-08-04T15:18:32Z

+      </Card.Body>
+      <Card.Divider />
+      <Card.Footer className="p-0 mt-2.5">
+        <Button variant="outline-danger" onClick={() => onDelete(idx)}>


Suggested change

<Button variant="outline-danger" onClick={() => onDelete(idx)}>

<Button variant="outline-primary" onClick={() => onDelete(idx)}>

KristinAoki · 2023-08-04T15:18:57Z

+            onChange={(e) => onChange(e.target.value, 'introVideo')}
+          />
+          <Button
+            variant="outline-danger"


Suggested change

variant="outline-danger"

variant="outline-primary"

KristinAoki · 2023-08-04T15:19:22Z

+        onChange={(e) => handleInputChange(e.target.value, idx)}
+      />
+      <Button
+        variant="outline-danger"


Suggested change

variant="outline-danger"

variant="outline-primary"

KristinAoki · 2023-08-04T15:22:11Z

What was the reasoning behind using dropdown instead of form.control with the type equal to select? Mainly for curiosity, doesn't require any changes.

KristinAoki · 2023-08-04T16:02:56Z

I also recommend merging in the latest release of frontend-lib-content-components to this PR as it a requirement for this PR.

ruzniaievdm · 2023-08-07T08:15:14Z

@KristinAoki in my opinion we used Dropdown only because of the styling of the components, if we don't have a need for it, I can rewrite it to custom select

ruzniaievdm · 2023-08-07T10:09:07Z

@KristinAoki referring to these changes we need to delete MFE urls.

After these changes utility getPagePath has been broken.

So can you explain me why during developing MFE pages we should remove process.env.ENABLE_SOME_PAGE_PAGES?

In this case where should the links to the pages in the sidebar to MFE or LEGACY lead to?

KristinAoki · 2023-08-07T13:12:43Z

@KristinAoki in my opinion we used Dropdown only because of the styling of the components, if we don't have a need for it, I can rewrite it to custom select

You can continue to use the Dropdown component. I was just curious since they both offer the same functionality and most forms use select.

KristinAoki · 2023-08-07T13:17:26Z

@KristinAoki referring to these changes we need to delete MFE urls.

After these changes utility getPagePath has been broken.

So can you explain me why during developing MFE pages we should remove process.env.ENABLE_SOME_PAGE_PAGES?

In this case where should the links to the pages in the sidebar to MFE or LEGACY lead to?

Sorry for the confusion. When TNL was originally setting up the course authoring MFE we thought env variables would be the best way to control access to the new pages. However, we have changed our approach and are going to rely exclusively on Django waffle flags and page redirects. Now all the links should lead to the LEGACY page.

ruzniaievdm · 2023-08-07T13:34:20Z

@KristinAoki thank you for your reply, I see your point, then in that case I remove the utility with the MFE/LEGACY selection and leave only references to LEGACY.

openedx-webhooks · 2023-08-08T13:49:58Z

@ruzniaievdm 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

* feat: configuration for xpert unit summaries (openedx#540) Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2 * fix: load up-to-date config on studio fetch (openedx#548) * refactor: added PropTypes declarations * feat: add files and uploads page (openedx#541) * fix: remove env variable for files and uploads (openedx#549) * Update verbiage for Xpert Settings (openedx#550) * chore: Update verbiage for Xpert configuration screen * fix: Change "generate" to "display" in xpert modal text * fix: Updated learn more link * fix: Change link and add targets * test: added test cases for hide discussion tab (openedx#552) Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> * feat: upgrade frontend-lib-content-components (openedx#554) * feat: bump frontend-lib-content-components (openedx#559) * fix: Change wording to not crowd xpert tile in preferences page (openedx#560) * fix: width and height of asset preview (openedx#558) * feat: flcc to 1.168.0 (openedx#561) * feat: bump frontend-lib-content-components (openedx#562) * fix: overflow-y scroll behavior (openedx#565) * test: added test cases of discussion restriction (openedx#556) * test: added test cases of discussion restriction * refactor: added null default value for dataTestId --------- Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> * fix: Add enabled badge to xpert settings tile (openedx#566) * feat: Add "Enabled" badge to xpert settings tile * fix: Update model with state instead of non-existent prop from response * feat: bump frontend-lib-content-components (openedx#569) * feat: Added Schedule and Details MFE page (openedx#547) * refactor: some refactoring --------- Co-authored-by: David Nuon <davidnuongm@gmail.com> Co-authored-by: Zachary Hancock <zhancock@edx.org> Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> Co-authored-by: sundasnoreen12 <72802712+sundasnoreen12@users.noreply.github.com> Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> Co-authored-by: Raymond Zhou <56318341+rayzhou-bit@users.noreply.github.com> Co-authored-by: ruzniaievdm <ruzniaievdm@gmail.com>

* feat: moving new commits from upstream repository (#62) * feat: configuration for xpert unit summaries (openedx#540) Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2 * fix: load up-to-date config on studio fetch (openedx#548) * refactor: added PropTypes declarations * feat: add files and uploads page (openedx#541) * fix: remove env variable for files and uploads (openedx#549) * Update verbiage for Xpert Settings (openedx#550) * chore: Update verbiage for Xpert configuration screen * fix: Change "generate" to "display" in xpert modal text * fix: Updated learn more link * fix: Change link and add targets * test: added test cases for hide discussion tab (openedx#552) Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> * feat: upgrade frontend-lib-content-components (openedx#554) * feat: bump frontend-lib-content-components (openedx#559) * fix: Change wording to not crowd xpert tile in preferences page (openedx#560) * fix: width and height of asset preview (openedx#558) * feat: flcc to 1.168.0 (openedx#561) * feat: bump frontend-lib-content-components (openedx#562) * fix: overflow-y scroll behavior (openedx#565) * test: added test cases of discussion restriction (openedx#556) * test: added test cases of discussion restriction * refactor: added null default value for dataTestId --------- Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> * fix: Add enabled badge to xpert settings tile (openedx#566) * feat: Add "Enabled" badge to xpert settings tile * fix: Update model with state instead of non-existent prop from response * feat: bump frontend-lib-content-components (openedx#569) * feat: Added Schedule and Details MFE page (openedx#547) * refactor: some refactoring --------- Co-authored-by: David Nuon <davidnuongm@gmail.com> Co-authored-by: Zachary Hancock <zhancock@edx.org> Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> Co-authored-by: sundasnoreen12 <72802712+sundasnoreen12@users.noreply.github.com> Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> Co-authored-by: Raymond Zhou <56318341+rayzhou-bit@users.noreply.github.com> Co-authored-by: ruzniaievdm <ruzniaievdm@gmail.com> * fix: Course updates - wrong datepicker value (#65) * fix: [2u-631] fixed date checking * fix: [2u-631] fixed validation schema * fix: [2u-631] fixed indents * feat: Course outline - Section highlights (#60) * feat: [2u-336] add tests * feat: [2u-271] fix button * feat: [2u-336] add component, refactor header * feat: [2u-342] add modal * fix: [2u-342] fix translates and indents * feat: [2u-342] add modal * feat: [2u-342] add api * feat: [2u-342] add tests and translates * feat: [2u-342] fix indents * fix: [2u-342] fix indents, variant and utils * feat: [2u-342] fixed slice, thunks, hooks * fix: [2u-342] fix translates * fix: [2u-342] fix api --------- Co-authored-by: Vladislav Keblysh <vladislavkeblysh@Vladislavs-MacBook-Pro.local> * feat: create organization filter on home page --------- Co-authored-by: Peter Kulko <93188219+PKulkoRaccoonGang@users.noreply.github.com> Co-authored-by: David Nuon <davidnuongm@gmail.com> Co-authored-by: Zachary Hancock <zhancock@edx.org> Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> Co-authored-by: sundasnoreen12 <72802712+sundasnoreen12@users.noreply.github.com> Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> Co-authored-by: Raymond Zhou <56318341+rayzhou-bit@users.noreply.github.com> Co-authored-by: vladislavkeblysh <138868841+vladislavkeblysh@users.noreply.github.com> Co-authored-by: Vladislav Keblysh <vladislavkeblysh@Vladislavs-MacBook-Pro.local>

ruzniaievdm added 7 commits August 1, 2023 14:39

feat: Create MFE page with base structure for schedule and details (#5)

6e6afc2

* feat: Create MFE page with base structure for schedule and details

feat: Add Course schedule section to the MFE page (#10)

cd5895d

* feat: Add Course schedule section to the MFE page * fix: after demo and resolve discussions * resolve discussions round 2

feat: Add default views for Course Details and Introduce Your Course … (

8cbefe9

#12) * feat: Add default views for Course Details and Introduce Your Course sections * fix: resolve discussions

feat: Add additional variants for Course Details and Introduce Your C…

941ac10

…ourse sections (#13)

fix: Schedule and details bugs 1 part

af8702e

fix: add internet connection alert on advanced settings page

1813d2e

feat: Add Requirements and Licensing section (#18)

ffb7f0f

* feat: Add Requirements and Licensing section * fix: add stateful button for saving advanced settings

ruzniaievdm force-pushed the ruzniaievdm/feat/schedule-and-details-mfe branch 2 times, most recently from d33b237 to c14da57 Compare August 1, 2023 15:57

ruzniaievdm added 5 commits August 1, 2023 19:17

fix: internet connection and constanst on license section

7678d89

fix: discussions on schedule and details page, hide cancel button, show success alert, internet connection

feat: Add wysiwyg editor

f59b470

fix: resolve discussions

3475db3

fix: add docs

a029ad4

fix: schedule & details resolve bugs

ee51f9d

ruzniaievdm force-pushed the ruzniaievdm/feat/schedule-and-details-mfe branch 2 times, most recently from 48f492c to 88981a3 Compare August 1, 2023 16:51

ruzniaievdm mentioned this pull request Aug 1, 2023

feat: Add TinyMceWidget on export openedx-unsupported/frontend-lib-content-components#365

Merged

ruzniaievdm force-pushed the ruzniaievdm/feat/schedule-and-details-mfe branch from 88981a3 to 29fb06e Compare August 1, 2023 17:13

ruzniaievdm mentioned this pull request Aug 1, 2023

fix: api for schedule and details page MFE page openedx/openedx-platform#32890

Merged

ruzniaievdm force-pushed the ruzniaievdm/feat/schedule-and-details-mfe branch 6 times, most recently from 8e93a8e to 8ca4e48 Compare August 3, 2023 09:13

ruzniaievdm force-pushed the ruzniaievdm/feat/schedule-and-details-mfe branch from 8ca4e48 to 611bdda Compare August 3, 2023 09:30

ruzniaievdm force-pushed the ruzniaievdm/feat/schedule-and-details-mfe branch from 611bdda to 9554703 Compare August 3, 2023 09:47

ruzniaievdm marked this pull request as ready for review August 3, 2023 09:56

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 3, 2023

KristinAoki suggested changes Aug 4, 2023

View reviewed changes

fix: resolve discussions upstream

bf680ea

ruzniaievdm requested a review from KristinAoki August 7, 2023 11:37

KristinAoki approved these changes Aug 7, 2023

View reviewed changes

mphilbrick211 requested a review from a team August 7, 2023 14:51

chore: refactor HelpSidebar with only legacy ulrs

8345ad6

KristinAoki approved these changes Aug 8, 2023

View reviewed changes

chore: added package-lock.json

9b97f87

KristinAoki merged commit a0e37c0 into openedx:master Aug 8, 2023

peterkulko pushed a commit to raccoongang/frontend-app-course-authoring that referenced this pull request Aug 21, 2023

feat: Added Schedule and Details MFE page (openedx#547)

19fb2bc

snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024

feat: Added Schedule and Details MFE page (openedx#547)

ad25218

kenclary mentioned this pull request Jan 9, 2024

fix: configure webpack to fix paid powerpaste plugin #783

Merged

	<Button iconBefore={AddIcon} variant="outline-success" onClick={handleAdd}>
	<Button iconBefore={AddIcon} variant="primary" onClick={handleAdd}>

	<Button variant="outline-danger" onClick={() => onDelete(idx)}>
	<Button variant="outline-primary" onClick={() => onDelete(idx)}>

Uh oh!

Conversation

ruzniaievdm commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Please merge it after

Uh oh!

codecov Bot commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

openedx-webhooks commented Aug 3, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KristinAoki commented Aug 4, 2023

Uh oh!

KristinAoki commented Aug 4, 2023

Uh oh!

ruzniaievdm commented Aug 7, 2023

Uh oh!

ruzniaievdm commented Aug 7, 2023

Uh oh!

KristinAoki commented Aug 7, 2023

Uh oh!

KristinAoki commented Aug 7, 2023

Uh oh!

ruzniaievdm commented Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openedx-webhooks commented Aug 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ruzniaievdm commented Aug 1, 2023 •

edited

Loading

codecov Bot commented Aug 3, 2023 •

edited

Loading

ruzniaievdm commented Aug 7, 2023 •

edited

Loading