fix: configure webpack to fix paid powerpaste plugin - #783
Merged
Conversation
jesperhodge
requested changes
Jan 9, 2024
| } | ||
| }); | ||
|
|
||
| config.module.rules[0].exclude = /node_modules\/(?!(query-string|split-on-first|strict-uri-encode|@edx))/; |
Contributor
There was a problem hiding this comment.
is this line necessary?
|
|
||
| const config = createConfig('webpack-prod', { | ||
| resolve: { | ||
| modules: [ |
Contributor
There was a problem hiding this comment.
we copied this over from the other repo, but I don't see the necessity for this modules array
kenclary
force-pushed
the
kenclary/webpack
branch
2 times, most recently
from
January 9, 2024 20:52
efc5324 to
e513ebe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #783 +/- ##
=========================================
Coverage ? 89.62%
=========================================
Files ? 499
Lines ? 8098
Branches ? 1710
=========================================
Hits ? 7258
Misses ? 813
Partials ? 27 ☔ View full report in Codecov by Sentry. |
kenclary
force-pushed
the
kenclary/webpack
branch
from
January 9, 2024 20:55
e513ebe to
3961d16
Compare
jesperhodge
approved these changes
Jan 9, 2024
kenclary
force-pushed
the
kenclary/webpack
branch
from
January 9, 2024 21:06
3961d16 to
74ea419
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: configure webpack to fix paid powerpaste plugin