Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

feat: Add TinyMceWidget on export - #365

Merged
KristinAoki merged 2 commits into
openedx-unsupported:mainfrom
raccoongang:ruzniaievdm/feat/wysiwyg-editor
Aug 3, 2023
Merged

feat: Add TinyMceWidget on export#365
KristinAoki merged 2 commits into
openedx-unsupported:mainfrom
raccoongang:ruzniaievdm/feat/wysiwyg-editor

Conversation

@ruzniaievdm

@ruzniaievdm ruzniaievdm commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

Description

This is part of Schedule & Details PR on 2U-Studio-MFE. Please add this changes to 1.163.1 tag

  • added TinyMceWidget on export

Please merge it before

  • frontend-app-course-authoring PR

@ruzniaievdm
ruzniaievdm marked this pull request as ready for review August 3, 2023 09:56
@codecov

codecov Bot commented Aug 3, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (38b85f7) 90.34% compared to head (c5803ee) 90.32%.

❗ Current head c5803ee differs from pull request most recent head 842ba0f. Consider uploading reports for the commit 842ba0f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   90.34%   90.32%   -0.03%     
==========================================
  Files         226      226              
  Lines        4018     4019       +1     
  Branches      797      797              
==========================================
  Hits         3630     3630              
- Misses        369      370       +1     
  Partials       19       19              
Files Changed Coverage Δ
...c/editors/sharedComponents/TinyMceWidget/index.jsx 93.75% <0.00%> (-6.25%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 3, 2023
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @ruzniaievdm! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

id: PropTypes.string,
disabled: PropTypes.bool,
editorContentHtml: PropTypes.string,
updateContent: PropTypes.func,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define this prop in the test to make code coverage match

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thx, i've added!

@KristinAoki
KristinAoki merged commit d25ae09 into openedx-unsupported:main Aug 3, 2023
@openedx-webhooks

Copy link
Copy Markdown

@ruzniaievdm 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@jesperhodge jesperhodge mentioned this pull request Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants