feat: Add Course schedule section to the MFE page - #10
Merged
Merged
Conversation
peterkulko
reviewed
Jun 18, 2023
|
@GlugovGrGlib asked to add a link to the ticket, please 👍 |
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/course-schedule-mfe
branch
from
June 19, 2023 12:15
904acbf to
dd58c90
Compare
peterkulko
approved these changes
Jun 19, 2023
sendr
reviewed
Jun 21, 2023
| <Button onClick={handleUpdateValues}> | ||
| <Button | ||
| onClick={handleUpdateValues} | ||
| disabled={Object.keys(errorFields).length} |
There was a problem hiding this comment.
Suggested change
| disabled={Object.keys(errorFields).length} | |
| disabled={hasErrors} |
| } | ||
|
|
||
| const showCreditSection = creditEligibilityEnabled && isCreditCourse; | ||
| const hasErrors = Object.keys(errorFields).length; |
There was a problem hiding this comment.
it, probably, should be a boolean value, not a number
| /> | ||
| ); | ||
| } | ||
| const { rowType, key, ...restProps } = fieldProps; |
Author
There was a problem hiding this comment.
Yes, we should no need to pass extra props to component
sendr
approved these changes
Jun 21, 2023
ruzniaievdm
added a commit
that referenced
this pull request
Aug 1, 2023
* feat: Add Course schedule section to the MFE page * fix: after demo and resolve discussions * resolve discussions round 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Course Schedule section is added to the Page and is editable
YT:
https://youtrack.raccoongang.com/issue/2U-99