feat: Add Requirements and Licensing section - #18
Merged
Merged
Conversation
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/requirements-and-licence-mfe
branch
3 times, most recently
from
July 6, 2023 09:32
a91d565 to
2409f68
Compare
ruzniaievdm
marked this pull request as ready for review
July 6, 2023 09:35
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/requirements-and-licence-mfe
branch
from
July 6, 2023 11:37
2409f68 to
319c42f
Compare
Author
|
@sendr please merge in separate commits |
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/requirements-and-licence-mfe
branch
from
July 6, 2023 11:43
319c42f to
832485d
Compare
sendr
reviewed
Jul 7, 2023
| import { LICENSE_COMMONS_OPTIONS } from './constants'; | ||
|
|
||
| const generateLicenseURL = (details) => { | ||
| const url = 'https://creativecommons.org/licenses/'; |
|
|
||
| const updatedString = `${ | ||
| LICENSE_TYPE.creativeCommons | ||
| }: ver=4.0 ${orderedDetails.join(' ')}`; |
| .map(([key]) => LICENSE_COMMONS_OPTIONS[key].toLowerCase()) | ||
| .join('-'); | ||
|
|
||
| return `${url}${detailsString}/4.0/`; |
There was a problem hiding this comment.
let's also not hardcode the version, I saw you use it twice
sendr
approved these changes
Jul 7, 2023
ruzniaievdm
added a commit
that referenced
this pull request
Aug 1, 2023
* feat: Add Requirements and Licensing section * fix: add stateful button for saving advanced settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2U-117
edx-platform need to merge too