feat: add files and uploads page by KristinAoki · Pull Request #541 · openedx/frontend-app-authoring

KristinAoki · 2023-07-25T17:09:00Z

JIRA Ticket: TNL-10908
Figma

Setup for tests:

npm install
npm run build (necessary to load new environment variable values)
npm start

Test:

Switching between grid and list view
Bulk delete files
Bulk download files
Bulk add files
Menu delete
Menu download
Menu lock/unlock file
Empty asset state has dropzone and no table action buttons
Dropzone add single file
Asset info modal lock/unlock

codecov · 2023-07-31T23:52:00Z

Codecov Report

Patch coverage: 91.27% and project coverage change: +2.57% 🎉

Comparison is base (8bfc3f2) 78.20% compared to head (921e7d4) 80.77%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   78.20%   80.77%   +2.57%     
==========================================
  Files         145      168      +23     
  Lines        2698     3106     +408     
  Branches      632      706      +74     
==========================================
+ Hits         2110     2509     +399     
- Misses        558      565       +7     
- Partials       30       32       +2

Files Changed	Coverage Δ
src/store.js	`100.00% <ø> (ø)`
src/files-and-uploads/FileThumbnail.jsx	`45.45% <45.45%> (ø)`
src/files-and-uploads/FileMenu.jsx	`66.66% <66.66%> (ø)`
src/files-and-uploads/ApiStatusToast.jsx	`71.42% <71.42%> (ø)`
...rc/files-and-uploads/table-components/ListCard.jsx	`80.00% <80.00%> (ø)`
src/files-and-uploads/FileInfo.jsx	`81.81% <81.81%> (ø)`
...iles-and-uploads/table-components/TableActions.jsx	`83.33% <83.33%> (ø)`
src/files-and-uploads/FilesAndUploads.jsx	`84.61% <84.61%> (ø)`
src/CourseAuthoringRoutes.jsx	`100.00% <100.00%> (ø)`
src/files-and-uploads/FileInput.jsx	`100.00% <100.00%> (ø)`
... and 9 more

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

connorhaugh · 2023-08-01T14:43:09Z

Looks like you still need to add tests for redux and tablecomponents.

connorhaugh · 2023-08-04T11:45:50Z

+      link.target = '_blank';
+      link.download = true;
+      link.href = externalUrl;
+      link.click();


This opens a bunch of blank tabs which may be disturbing to the user ux wise but i agree its the solution until we can implement zip files.

Looks like the biggest library for this (jszip) hasn't been contributed to in a year, so either is is perfect or dead.

yeah that is the library i have been looking into. I plan to work on the zipping after everything is done for the first pass.

connorhaugh · 2023-08-04T11:47:00Z

+
+  const headerActions = ({ selectedFlatRows }) => {
+    if (_.isEmpty(assets)) {
+      return [];


Why are we returning a list or a react component here? I know JS isn't type safe, but that seems risky.

Thanks for the catch! The parameter that is calling the function expects an array of components or a functional component. But the returned empty array is no longer needed because of how I control the view of the table control bar.

connorhaugh · 2023-08-04T11:49:46Z

+    setTotalCount: (state, { payload }) => {
+      state.totalCount = payload.totalCount;
+    },
+    updateLoadingStatus: (state, { payload }) => {


Did you think at all about bringing the request states framework from FLCC over to course authoring for this kind of stuff? If yes, why did you go with this approach?

I am using the patterns that already existed in this repo.

connorhaugh · 2023-08-04T11:53:32Z

Added some more js-level feedback. Code seems to be working properly but just trying to be thorough.

Co-authored-by: connorhaugh <49422820+connorhaugh@users.noreply.github.com>

connorhaugh

Nice work!

* feat: configuration for xpert unit summaries (openedx#540) Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2 * fix: load up-to-date config on studio fetch (openedx#548) * refactor: added PropTypes declarations * feat: add files and uploads page (openedx#541) * fix: remove env variable for files and uploads (openedx#549) * Update verbiage for Xpert Settings (openedx#550) * chore: Update verbiage for Xpert configuration screen * fix: Change "generate" to "display" in xpert modal text * fix: Updated learn more link * fix: Change link and add targets * test: added test cases for hide discussion tab (openedx#552) Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> * feat: upgrade frontend-lib-content-components (openedx#554) * feat: bump frontend-lib-content-components (openedx#559) * fix: Change wording to not crowd xpert tile in preferences page (openedx#560) * fix: width and height of asset preview (openedx#558) * feat: flcc to 1.168.0 (openedx#561) * feat: bump frontend-lib-content-components (openedx#562) * fix: overflow-y scroll behavior (openedx#565) * test: added test cases of discussion restriction (openedx#556) * test: added test cases of discussion restriction * refactor: added null default value for dataTestId --------- Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> * fix: Add enabled badge to xpert settings tile (openedx#566) * feat: Add "Enabled" badge to xpert settings tile * fix: Update model with state instead of non-existent prop from response * feat: bump frontend-lib-content-components (openedx#569) * feat: Added Schedule and Details MFE page (openedx#547) * refactor: some refactoring --------- Co-authored-by: David Nuon <davidnuongm@gmail.com> Co-authored-by: Zachary Hancock <zhancock@edx.org> Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> Co-authored-by: sundasnoreen12 <72802712+sundasnoreen12@users.noreply.github.com> Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> Co-authored-by: Raymond Zhou <56318341+rayzhou-bit@users.noreply.github.com> Co-authored-by: ruzniaievdm <ruzniaievdm@gmail.com>

* feat: moving new commits from upstream repository (#62) * feat: configuration for xpert unit summaries (openedx#540) Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2 * fix: load up-to-date config on studio fetch (openedx#548) * refactor: added PropTypes declarations * feat: add files and uploads page (openedx#541) * fix: remove env variable for files and uploads (openedx#549) * Update verbiage for Xpert Settings (openedx#550) * chore: Update verbiage for Xpert configuration screen * fix: Change "generate" to "display" in xpert modal text * fix: Updated learn more link * fix: Change link and add targets * test: added test cases for hide discussion tab (openedx#552) Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> * feat: upgrade frontend-lib-content-components (openedx#554) * feat: bump frontend-lib-content-components (openedx#559) * fix: Change wording to not crowd xpert tile in preferences page (openedx#560) * fix: width and height of asset preview (openedx#558) * feat: flcc to 1.168.0 (openedx#561) * feat: bump frontend-lib-content-components (openedx#562) * fix: overflow-y scroll behavior (openedx#565) * test: added test cases of discussion restriction (openedx#556) * test: added test cases of discussion restriction * refactor: added null default value for dataTestId --------- Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> * fix: Add enabled badge to xpert settings tile (openedx#566) * feat: Add "Enabled" badge to xpert settings tile * fix: Update model with state instead of non-existent prop from response * feat: bump frontend-lib-content-components (openedx#569) * feat: Added Schedule and Details MFE page (openedx#547) * refactor: some refactoring --------- Co-authored-by: David Nuon <davidnuongm@gmail.com> Co-authored-by: Zachary Hancock <zhancock@edx.org> Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> Co-authored-by: sundasnoreen12 <72802712+sundasnoreen12@users.noreply.github.com> Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> Co-authored-by: Raymond Zhou <56318341+rayzhou-bit@users.noreply.github.com> Co-authored-by: ruzniaievdm <ruzniaievdm@gmail.com> * fix: Course updates - wrong datepicker value (#65) * fix: [2u-631] fixed date checking * fix: [2u-631] fixed validation schema * fix: [2u-631] fixed indents * feat: Course outline - Section highlights (#60) * feat: [2u-336] add tests * feat: [2u-271] fix button * feat: [2u-336] add component, refactor header * feat: [2u-342] add modal * fix: [2u-342] fix translates and indents * feat: [2u-342] add modal * feat: [2u-342] add api * feat: [2u-342] add tests and translates * feat: [2u-342] fix indents * fix: [2u-342] fix indents, variant and utils * feat: [2u-342] fixed slice, thunks, hooks * fix: [2u-342] fix translates * fix: [2u-342] fix api --------- Co-authored-by: Vladislav Keblysh <vladislavkeblysh@Vladislavs-MacBook-Pro.local> * feat: create organization filter on home page --------- Co-authored-by: Peter Kulko <93188219+PKulkoRaccoonGang@users.noreply.github.com> Co-authored-by: David Nuon <davidnuongm@gmail.com> Co-authored-by: Zachary Hancock <zhancock@edx.org> Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> Co-authored-by: sundasnoreen12 <72802712+sundasnoreen12@users.noreply.github.com> Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> Co-authored-by: Raymond Zhou <56318341+rayzhou-bit@users.noreply.github.com> Co-authored-by: vladislavkeblysh <138868841+vladislavkeblysh@users.noreply.github.com> Co-authored-by: Vladislav Keblysh <vladislavkeblysh@Vladislavs-MacBook-Pro.local>

KristinAoki added 4 commits July 25, 2023 12:43

feat: show files and uploads page

68560f1

feat: update packages

2a83d6e

feat: add file and uploads components

cfdb63a

feat: add api functions

8a482ee

KristinAoki requested review from connorhaugh, jesperhodge, kenclary and rayzhou-bit July 25, 2023 17:09

KristinAoki added 8 commits July 25, 2023 13:15

Merge branch 'master' into KristinAoki/add-files-and-uploads

dda21fe

fix: lint errors

bfcca7a

Merge branch 'master' into KristinAoki/add-files-and-uploads

f29d433

chore: rename file

cf6d2e8

fix: console errors

f7ce7c2

fix: pagination page count error

06bf73b

chore: add files and uploads tests

97639d5

fix: lint warning count error

f5769b6

connorhaugh reviewed Aug 1, 2023

View reviewed changes

Comment thread src/files-and-uploads/ApiStatusToast.jsx Outdated

connorhaugh reviewed Aug 1, 2023

View reviewed changes

Comment thread src/files-and-uploads/FileInput.jsx Outdated

connorhaugh reviewed Aug 1, 2023

View reviewed changes

Comment thread src/files-and-uploads/FileMenu.jsx

KristinAoki added 6 commits August 1, 2023 12:34

fix: api fetch for all assets

232f267

chore: remove focus on file upload test

7e2f0e4

chore: add file menu tests

4b89b70

fix: move duplicate code into shared function

a4c0844

fix: broken mock api response

b1be395

fix: heap memory error

4a1e517

KristinAoki requested a review from connorhaugh August 3, 2023 14:29

KristinAoki added 2 commits August 3, 2023 10:56

fix: error alerts

3dbdced

fix: remove console logs

08e73cb

connorhaugh reviewed Aug 4, 2023

View reviewed changes

Comment thread src/files-and-uploads/FilesAndUploads.jsx Outdated

connorhaugh reviewed Aug 4, 2023

View reviewed changes

KristinAoki and others added 3 commits August 4, 2023 09:13

fix: fetch all variables from redux in one call

5c827b7

Co-authored-by: connorhaugh <49422820+connorhaugh@users.noreply.github.com>

fix: js errors

fca7a25

fix: broken test

921e7d4

connorhaugh approved these changes Aug 4, 2023

View reviewed changes

KristinAoki merged commit b9feb50 into master Aug 4, 2023

KristinAoki deleted the KristinAoki/add-files-and-uploads branch August 4, 2023 15:57

peterkulko pushed a commit to raccoongang/frontend-app-course-authoring that referenced this pull request Aug 21, 2023

feat: add files and uploads page (openedx#541)

b98ba9c

snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024

feat: add files and uploads page (openedx#541)

a403a6e

kenclary mentioned this pull request Jan 9, 2024

fix: configure webpack to fix paid powerpaste plugin #783

Merged

Navigation Menu

Uh oh!

feat: add files and uploads page - #541

feat: add files and uploads page#541
KristinAoki merged 23 commits into
masterfrom
KristinAoki/add-files-and-uploads

KristinAoki commented Jul 25, 2023

Uh oh!

codecov Bot commented Jul 31, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

connorhaugh commented Aug 1, 2023

Uh oh!

Uh oh!

connorhaugh Aug 4, 2023

Uh oh!

KristinAoki Aug 4, 2023

Uh oh!

connorhaugh Aug 4, 2023

Uh oh!

KristinAoki Aug 4, 2023

Uh oh!

connorhaugh Aug 4, 2023

Uh oh!

KristinAoki Aug 4, 2023

Uh oh!

connorhaugh commented Aug 4, 2023

Uh oh!

connorhaugh left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

KristinAoki commented Jul 25, 2023

Uh oh!

codecov Bot commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

connorhaugh commented Aug 1, 2023

Uh oh!

Uh oh!

connorhaugh Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

KristinAoki Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

connorhaugh Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

KristinAoki Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

connorhaugh Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

KristinAoki Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

connorhaugh commented Aug 4, 2023

Uh oh!

connorhaugh left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Jul 31, 2023 •

edited

Loading