feat: configuration for xpert unit summaries by davidnuon · Pull Request #540 · openedx/frontend-app-authoring

davidnuon · 2023-07-25T16:57:56Z

Add new section and configuration for Xpert Unit Summaries

Used to configure: edx/ai-aside#38

Screencasts

The dialog option

Screen.Recording.2023-07-25.at.10.06.27.AM.mov

Toggling showing the config option in the Pages and Resources screen

Screen.Recording.2023-07-31.at.10.19.18.AM.mov

Adds setting modal for Xpert unit summaries

aethant

just need to fix spacing issues on the one file, otherwise, lgtm

codecov · 2023-07-25T17:26:23Z

Codecov Report

Patch coverage: 85.24% and project coverage change: +0.34% 🎉

Comparison is base (8bfc3f2) 78.20% compared to head (d478ead) 78.54%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
+ Coverage   78.20%   78.54%   +0.34%     
==========================================
  Files         145      151       +6     
  Lines        2698     2820     +122     
  Branches      632      661      +29     
==========================================
+ Hits         2110     2215     +105     
- Misses        558      574      +16     
- Partials       30       31       +1

Files Changed	Coverage Δ
src/pages-and-resources/messages.js	`100.00% <ø> (ø)`
src/pages-and-resources/PagesAndResources.jsx	`61.29% <66.66%> (-2.71%)`	⬇️
...pert-unit-summary/settings-modal/SettingsModal.jsx	`79.66% <79.66%> (ø)`
...es-and-resources/xpert-unit-summary/data/thunks.js	`87.87% <87.87%> (ø)`
...es/xpert-unit-summary/XpertUnitSummarySettings.jsx	`100.00% <100.00%> (ø)`
...pages-and-resources/xpert-unit-summary/data/api.js	`100.00% <100.00%> (ø)`
...pages-and-resources/xpert-unit-summary/messages.js	`100.00% <100.00%> (ø)`
...rces/xpert-unit-summary/settings-modal/messages.js	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

schenedx · 2023-07-25T17:30:18Z

Is your plan to write unit test together in this PR? That make sense. This early view makes reviewing much easier than with all those spec files.

rijuma

Looks good to me. I just left a comment for the use of awaits on state setters.
It would be awesome if PRs with UI changes get also some screenshots for context.

davidnuon · 2023-07-25T18:39:39Z

Is your plan to write unit test together in this PR? That make sense. This early view makes reviewing much easier than with all those spec files.

yep, that's the plan

This is done based on a flag from edx/ai-aside@3d113d2

ashultz0

things I wanted are all set :)

Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2

* feat: configuration for xpert unit summaries (openedx#540) Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2 * fix: load up-to-date config on studio fetch (openedx#548) * refactor: added PropTypes declarations * feat: add files and uploads page (openedx#541) * fix: remove env variable for files and uploads (openedx#549) * Update verbiage for Xpert Settings (openedx#550) * chore: Update verbiage for Xpert configuration screen * fix: Change "generate" to "display" in xpert modal text * fix: Updated learn more link * fix: Change link and add targets * test: added test cases for hide discussion tab (openedx#552) Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> * feat: upgrade frontend-lib-content-components (openedx#554) * feat: bump frontend-lib-content-components (openedx#559) * fix: Change wording to not crowd xpert tile in preferences page (openedx#560) * fix: width and height of asset preview (openedx#558) * feat: flcc to 1.168.0 (openedx#561) * feat: bump frontend-lib-content-components (openedx#562) * fix: overflow-y scroll behavior (openedx#565) * test: added test cases of discussion restriction (openedx#556) * test: added test cases of discussion restriction * refactor: added null default value for dataTestId --------- Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> * fix: Add enabled badge to xpert settings tile (openedx#566) * feat: Add "Enabled" badge to xpert settings tile * fix: Update model with state instead of non-existent prop from response * feat: bump frontend-lib-content-components (openedx#569) * feat: Added Schedule and Details MFE page (openedx#547) * refactor: some refactoring --------- Co-authored-by: David Nuon <davidnuongm@gmail.com> Co-authored-by: Zachary Hancock <zhancock@edx.org> Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> Co-authored-by: sundasnoreen12 <72802712+sundasnoreen12@users.noreply.github.com> Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> Co-authored-by: Raymond Zhou <56318341+rayzhou-bit@users.noreply.github.com> Co-authored-by: ruzniaievdm <ruzniaievdm@gmail.com>

* feat: moving new commits from upstream repository (#62) * feat: configuration for xpert unit summaries (openedx#540) Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2 * fix: load up-to-date config on studio fetch (openedx#548) * refactor: added PropTypes declarations * feat: add files and uploads page (openedx#541) * fix: remove env variable for files and uploads (openedx#549) * Update verbiage for Xpert Settings (openedx#550) * chore: Update verbiage for Xpert configuration screen * fix: Change "generate" to "display" in xpert modal text * fix: Updated learn more link * fix: Change link and add targets * test: added test cases for hide discussion tab (openedx#552) Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> * feat: upgrade frontend-lib-content-components (openedx#554) * feat: bump frontend-lib-content-components (openedx#559) * fix: Change wording to not crowd xpert tile in preferences page (openedx#560) * fix: width and height of asset preview (openedx#558) * feat: flcc to 1.168.0 (openedx#561) * feat: bump frontend-lib-content-components (openedx#562) * fix: overflow-y scroll behavior (openedx#565) * test: added test cases of discussion restriction (openedx#556) * test: added test cases of discussion restriction * refactor: added null default value for dataTestId --------- Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> * fix: Add enabled badge to xpert settings tile (openedx#566) * feat: Add "Enabled" badge to xpert settings tile * fix: Update model with state instead of non-existent prop from response * feat: bump frontend-lib-content-components (openedx#569) * feat: Added Schedule and Details MFE page (openedx#547) * refactor: some refactoring --------- Co-authored-by: David Nuon <davidnuongm@gmail.com> Co-authored-by: Zachary Hancock <zhancock@edx.org> Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> Co-authored-by: sundasnoreen12 <72802712+sundasnoreen12@users.noreply.github.com> Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> Co-authored-by: Raymond Zhou <56318341+rayzhou-bit@users.noreply.github.com> Co-authored-by: ruzniaievdm <ruzniaievdm@gmail.com> * fix: Course updates - wrong datepicker value (#65) * fix: [2u-631] fixed date checking * fix: [2u-631] fixed validation schema * fix: [2u-631] fixed indents * feat: Course outline - Section highlights (#60) * feat: [2u-336] add tests * feat: [2u-271] fix button * feat: [2u-336] add component, refactor header * feat: [2u-342] add modal * fix: [2u-342] fix translates and indents * feat: [2u-342] add modal * feat: [2u-342] add api * feat: [2u-342] add tests and translates * feat: [2u-342] fix indents * fix: [2u-342] fix indents, variant and utils * feat: [2u-342] fixed slice, thunks, hooks * fix: [2u-342] fix translates * fix: [2u-342] fix api --------- Co-authored-by: Vladislav Keblysh <vladislavkeblysh@Vladislavs-MacBook-Pro.local> * feat: create organization filter on home page --------- Co-authored-by: Peter Kulko <93188219+PKulkoRaccoonGang@users.noreply.github.com> Co-authored-by: David Nuon <davidnuongm@gmail.com> Co-authored-by: Zachary Hancock <zhancock@edx.org> Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> Co-authored-by: sundasnoreen12 <72802712+sundasnoreen12@users.noreply.github.com> Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> Co-authored-by: Raymond Zhou <56318341+rayzhou-bit@users.noreply.github.com> Co-authored-by: vladislavkeblysh <138868841+vladislavkeblysh@users.noreply.github.com> Co-authored-by: Vladislav Keblysh <vladislavkeblysh@Vladislavs-MacBook-Pro.local>

Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2

davidnuon changed the title ~~[wip] feat: configuration for xpert unit summaries~~ [wip] [don't merge] feat: configuration for xpert unit summaries Jul 25, 2023

davidnuon changed the title ~~[wip] [don't merge] feat: configuration for xpert unit summaries~~ feat: configuration for xpert unit summaries Jul 25, 2023

feat: Add setting for Xpert unit summaries

04d2312

Adds setting modal for Xpert unit summaries

davidnuon force-pushed the davidnuon/configuration-for-xpert-summaries branch from 715bbb7 to 04d2312 Compare July 25, 2023 17:10

aethant approved these changes Jul 25, 2023

View reviewed changes

style: Fix linting to 2-spaces

1a34e52

ashultz0 reviewed Jul 25, 2023

View reviewed changes

Comment thread src/pages-and-resources/PagesAndResources.jsx Outdated

rijuma reviewed Jul 25, 2023

View reviewed changes

Comment thread src/pages-and-resources/xpert-unit-summary/settings-modal/SettingsModal.jsx Outdated

rijuma reviewed Jul 25, 2023

View reviewed changes

Comment thread src/pages-and-resources/xpert-unit-summary/settings-modal/SettingsModal.jsx

feat: Change copy for Xpert config dialog

ed52c90

ashultz0 reviewed Jul 25, 2023

View reviewed changes

Comment thread src/pages-and-resources/xpert-unit-summary/data/api.js Outdated

davidnuon changed the title ~~feat: configuration for xpert unit summaries~~ [wip] [do no merge] feat: configuration for xpert unit summaries Jul 25, 2023

davidnuon added 5 commits July 31, 2023 07:31

test: Add tests for XpertUnitSummarySettings

b80181f

feat: Add hiding the config section for xpert summary

387c3ac

This is done based on a flag from edx/ai-aside@3d113d2

chore: Update PagesAndResources imports

a035aa2

Merge branch 'master' into davidnuon/configuration-for-xpert-summaries

7f2938d

style: Fix lint

ed4ba40

davidnuon force-pushed the davidnuon/configuration-for-xpert-summaries branch from bcc8f7b to ed4ba40 Compare July 31, 2023 17:06

davidnuon added 3 commits July 31, 2023 10:12

fix: Change to use STUDIO_BASE_URL instead of LMS_BASE_URL

8ce5f0d

test: Add tests for saving xpertconfigsettings

0badc4e

test: Update tests

a43ed0b

davidnuon force-pushed the davidnuon/configuration-for-xpert-summaries branch from 6613314 to a43ed0b Compare July 31, 2023 19:45

davidnuon changed the title ~~[wip] [do no merge] feat: configuration for xpert unit summaries~~ feat: configuration for xpert unit summaries Jul 31, 2023

fix: remove extraneous await in for setSaveError

d478ead

ashultz0 approved these changes Jul 31, 2023

View reviewed changes

rijuma approved these changes Jul 31, 2023

View reviewed changes

ashultz0 merged commit 1dba620 into master Aug 1, 2023

ashultz0 deleted the davidnuon/configuration-for-xpert-summaries branch August 1, 2023 13:07

kenclary mentioned this pull request Jan 9, 2024

fix: configure webpack to fix paid powerpaste plugin #783

Merged

Navigation Menu

Uh oh!

feat: configuration for xpert unit summaries - #540

feat: configuration for xpert unit summaries#540
ashultz0 merged 12 commits into
masterfrom
davidnuon/configuration-for-xpert-summaries

davidnuon commented Jul 25, 2023 •

edited

Loading

Uh oh!

aethant left a comment

Uh oh!

codecov Bot commented Jul 25, 2023 •

edited

Loading

Uh oh!

schenedx commented Jul 25, 2023

Uh oh!

Uh oh!

rijuma left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidnuon commented Jul 25, 2023

Uh oh!

ashultz0 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

davidnuon commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screencasts

The dialog option

Toggling showing the config option in the Pages and Resources screen

Uh oh!

aethant left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

schenedx commented Jul 25, 2023

Uh oh!

Uh oh!

rijuma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidnuon commented Jul 25, 2023

Uh oh!

ashultz0 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

davidnuon commented Jul 25, 2023 •

edited

Loading

codecov Bot commented Jul 25, 2023 •

edited

Loading