build: fix notify-on-review-wanted action #55304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
marco-ippolito
approved these changes
Oct 7, 2024
RafaelGSS
added
the
author ready
lpinca
approved these changes
Oct 7, 2024
|
Fast-track has been requested by @lpinca. Please 👍 to approve. |
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55304 ✔ Done loading data for nodejs/node/pull/55304 ----------------------------------- PR info ------------------------------------ Title build: fix notify-on-review-wanted action (#55304) Author Rafael Gonzaga <[email protected]> (@RafaelGSS) Branch RafaelGSS:fix-notify-review-wanted-label -> nodejs:main Labels meta, fast-track, author ready Commits 1 - build: fix notify-on-review-wanted action Committers 1 - RafaelGSS <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55304 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55304 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 07 Oct 2024 15:32:22 GMT ✔ Approvals: 2 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/55304#pullrequestreview-2352316368 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55304#pullrequestreview-2352349684 ℹ This PR is being fast-tracked ✘ This PR needs to wait 47 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11219604418 |
LiviaMedeiros
removed
the
commit-queue-failed
LiviaMedeiros
approved these changes
Oct 7, 2024
LiviaMedeiros
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ae1e2b5 |
aduh95
pushed a commit
that referenced
this pull request
Oct 9, 2024
PR-URL: #55304 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55304 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled