Revert "build: upgrade clang-format to v18" #54994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c3e1c31.
targos
approved these changes
Sep 18, 2024
marco-ippolito
approved these changes
Sep 18, 2024
😅Sorry! I should've checked the output of a complete format before allowing the PR to be merged. |
RedYetiDev
added
c++
richardlau
approved these changes
Sep 18, 2024
richardlau
added
the
fast-track
|
CC @magic-akari |
|
Fast-track has been requested by @richardlau. Please 👍 to approve. |
anonrig
approved these changes
Sep 18, 2024
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7e00be7 |
|
Somehow after this revert, I am still seeing this strange cut-off env.cc thing both in the Github actions (https://github.com/nodejs/node/actions/runs/10900721511/job/30436607404?pr=54971) and locally for #54971 - I tried to rebase and re-ran make format-cpp-build locally, but it is still showing up. |
|
Managed to fix it locally by running |
|
My apologies for the inconvenience I've caused. |
|
No worries! Alls well that ends well. |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
This reverts commit c3e1c31. PR-URL: #54994 Refs: #53957 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
This reverts commit c3e1c31. PR-URL: nodejs#54994 Refs: nodejs#53957 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c3e1c31.
@wasm-fmt/clang-formatoutputs incompleteenv.cc(81K) ornode_contextify.cc(69K) with any changes in it.Refs: #54993 (comment)
Refs: #53957