assert: show the diff when deep comparing data with a custom message #54759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54759 +/- ##
=======================================
Coverage 87.60% 87.61%
=======================================
Files 650 650
Lines 182829 182836 +7
Branches 35379 35381 +2
=======================================
+ Hits 160173 160185 +12
+ Misses 15928 15926 -2
+ Partials 6728 6725 -3
|
puskin94
force-pushed
the
show-diff-in-comparison-with-custom-message
branch
from
89cb67f
to
0d996bc
Compare
|
@RedYetiDev, do you think we should tag someone or ask for a review from the assert/test group? Edit: Maybe @MoLow would be interested in reviewing this (I saw this #48465 (comment)) |
|
CC @nodejs/assert |
|
Any news on this? is this ready to land? |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
The PR is ready but the CI is flaky |
aduh95
approved these changes
Sep 24, 2024
jasnell
approved these changes
Sep 28, 2024
jasnell
pushed a commit
that referenced
this pull request
Sep 28, 2024
Fixes: #48465 PR-URL: #54759 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in e1d8b4f |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
Fixes: #48465 PR-URL: #54759 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
Fixes: #48465 PR-URL: #54759 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Fixes: nodejs#48465 PR-URL: nodejs#54759 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48465
This PR allows some assertion methods to show the diff when 2 data are different and a custom error message is passed
From this:
To this: