cli: fix spacing for port range error #54495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54495 +/- ##
=======================================
Coverage 87.34% 87.34%
=======================================
Files 649 649
Lines 182544 182524 -20
Branches 35030 35028 -2
=======================================
- Hits 159445 159428 -17
Misses 16372 16372
+ Partials 6727 6724 -3
|
anonrig
approved these changes
Aug 22, 2024
lpinca
approved these changes
Aug 23, 2024
github-actions
bot
removed
the
request-ci
|
It's been a week since the last CI, however the failures appear to flakes. I assume it needs another run, right? |
|
2 weeks have passed... I've started a new CI, as the last one is old. |
github-actions
bot
removed
the
request-ci
RedYetiDev
added
the
author ready
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 65768bc |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54495 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54495 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
node: must be 0 or in range 1024 to 65535.After
node: must be 0 or in range 1024 to 65535.Note the double spacing in the before comparison.