Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: handle --input-type more consistently #54979

Merged
merged 1 commit into from
Sep 19, 2024
Merged

worker: handle --input-type more consistently #54979

merged 1 commit into from
Sep 19, 2024
+12 −2

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 17, 2024

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 17, 2024
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62493/

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (d2a4f92) to head (2bc83c5).
Report is 31 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54979   +/-   ##
=======================================
  Coverage   88.07%   88.07%           
=======================================
  Files         652      652           
  Lines      183546   183548    +2     
  Branches    35859    35861    +2     
=======================================
+ Hits       161649   161656    +7     
- Misses      15147    15149    +2     
+ Partials     6750     6743    -7
Files with missing lines Coverage Δ
lib/internal/main/worker_thread.js 95.47% <100.00%> (+0.03%) ⬆️

... and 35 files with indirect coverage changes

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6031a4b into nodejs:main Sep 19, 2024
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6031a4b

@aduh95 aduh95 deleted the worker-input-type-eval branch September 19, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Worker eval as ES Module
5 participants
@aduh95 @nodejs-github-bot @lpinca @targos @marco-ippolito