benchmark: adjust config for deepEqual object #55254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make easier to read on benchmark/compare and when generating graphs
|
Review requested:
|
nodejs-github-bot
added
assert
RedYetiDev
reviewed
Oct 3, 2024
|
I will add the review-wanted label just to test if that's working :) |
|
RafaelGSS
added
review wanted
H4ad
approved these changes
Oct 8, 2024
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55254 ✔ Done loading data for nodejs/node/pull/55254 ----------------------------------- PR info ------------------------------------ Title benchmark: adjust config for deepEqual object (#55254) Author Rafael Gonzaga <[email protected]> (@RafaelGSS) Branch RafaelGSS:adjust-deep-equal-object -> nodejs:main Labels assert, benchmark, review wanted Commits 2 - benchmark: adjust config for deepEqual object - fixup! benchmark: adjust config for deepEqual object Committers 1 - RafaelGSS <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55254 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55254 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 03 Oct 2024 17:36:07 GMT ✔ Approvals: 1 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/55254#pullrequestreview-2353309295 ✘ This PR needs to wait 4 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11275081403 |
RafaelGSS
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in aeadaba |
aduh95
pushed a commit
that referenced
this pull request
Oct 11, 2024
This should make easier to read on benchmark/compare and when generating graphs PR-URL: #55254 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Oct 14, 2024
This should make easier to read on benchmark/compare and when generating graphs PR-URL: nodejs#55254 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Oct 19, 2024
This should make easier to read on benchmark/compare and when generating graphs PR-URL: #55254 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
This should make easier to read on benchmark/compare and when generating graphs PR-URL: nodejs#55254 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to read on benchmark/compare and when generating graphs