doc: fix link in test/README.md
#55165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
LiviaMedeiros
added
doc
MoLow
approved these changes
Sep 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55165 +/- ##
=======================================
Coverage 88.23% 88.24%
=======================================
Files 651 651
Lines 183863 183863
Branches 35824 35827 +3
=======================================
+ Hits 162235 162245 +10
+ Misses 14932 14923 -9
+ Partials 6696 6695 -1 |
RedYetiDev
added
the
fast-track
|
Fast-track has been requested by @RedYetiDev. Please 👍 to approve. |
|
Fast-tracking, as this is an extremely simple change, and shouldn't need to much deliberation? |
RedYetiDev
added
the
author ready
lpinca
approved these changes
Sep 30, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0f02810 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55165 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55165 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55165 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Nov 16, 2024
PR-URL: #55165 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Nov 17, 2024
PR-URL: #55165 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relative link points to wrong place when the page is opened as https://github.com/nodejs/node/tree/main/test (without trailing slash nor explicit
README.md), becausenew URL('./common/README.md', 'https://github.com/nodejs/node/tree/main/test').href === 'https://github.com/nodejs/node/tree/main/common/README.md'.Note that there are similar links in other places (example:
node/test/wpt/README.md
Line 8 in 103b843