Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.5.0 proposal #28268

Merged
merged 190 commits into from
Jun 27, 2019
Merged

v12.5.0 proposal #28268

merged 190 commits into from
Jun 27, 2019

Conversation

BridgeAR
Copy link
Member

Notable changes:

TBD

Commits:

  • [f03241fc0a] - (SEMVER-MINOR) assert: add partial support for evaluated code in simple assert (Ruben Bridgewater) #27781
  • [ef8f147b7e] - (SEMVER-MINOR) assert: improve regular expression validation (Ruben Bridgewater) #27781
  • [8157a50161] - assert: print more lines in the error diff (Ruben Bridgewater) #28058
  • [82174412a5] - assert: fix error diff (Ruben Bridgewater) #28058
  • [1ee7ce6092] - assert: limit string inspection when logging assertion errors (Ruben Bridgewater) #28058
  • [366c9831cd] - build: fix cctest target for --without-report (Richard Lau) #28238
  • [47dc5b2155] - build: guard test-doc recipe with node_use_openssl (Daniel Bevenius) #28199
  • [2201484541] - build: turn on custom V8 snapshot by default (Joyee Cheung) #28181
  • [7d0ffee435] - build: unbreak --with-intl=system-icu build (Ben Noordhuis) #28118
  • [0931f7e635] - build: fix icu-i18n pkg-config version check (Ben Noordhuis) #28118
  • [e2ad36482c] - build: don't swallow pkg-config warnings (Ben Noordhuis) #28118
  • [48d7d7c53e] - build: lint all docs under doc (Richard Lau) #28128
  • [d3207912fb] - build: fix configure script to work with Apple Clang 11 (Saagar Jha) #28071
  • [21bcfb67f6] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Refael Ackermann) #27375
  • [e5c26753e9] - build,meta: rearrange and narrow git ignore rules (Refael Ackermann) #27954
  • [5101e4c2a2] - (SEMVER-MAJOR) build,v8: sync V8 gypfiles with 7.5 (Refael Ackermann) #27375
  • [5a7154ef32] - build,win: delegate lint-cpp to make (Refael Ackermann) #28102
  • [3f1787b47d] - crypto: add debug info client emit secureConnect (Daniel Bevenius) #28067
  • [5fddde69bb] - deps: update archs files for OpenSSL-1.1.1c (Sam Roberts) #28211
  • [0a2353eb9a] - deps: upgrade openssl sources to 1.1.1c (Sam Roberts) #28211
  • [e46d9e9df7] - deps: updated openssl upgrade instructions (Sam Roberts) #28211
  • [084ffd8c2f] - deps: update llhttp to 1.1.4 (Fedor Indutny) #28154
  • [9382b3be9c] - deps: V8: cherry-pick e0a109c (Joyee Cheung) #27533
  • [b690e19a9a] - deps: ignore deps/.cipd fetched by deps/v8/tools/node/fetch_deps.py (Joyee Cheung) #28095
  • [d42ad64253] - deps: update node-inspect to v1.11.6 (Jan Krems) #28039
  • [40a1a11542] - (SEMVER-MINOR) deps: patch V8 to be API/ABI compatible with 7.4 (Michaël Zasso) #28005
  • [ad3a164ec3] - (SEMVER-MAJOR) deps: bump minimum icu version to 64 (Michaël Zasso) #27375
  • [e4aa869726] - (SEMVER-MAJOR) deps: V8: backport 3a75c1f (Refael Ackermann) #27375
  • [bb729a415a] - (SEMVER-MAJOR) deps: V8: fix BUILDING_V8_SHARED issues (Refael Ackermann) #27375
  • [f8a33abe0c] - (SEMVER-MAJOR) deps: V8: workaround for MSVC 14.20 optimizer bug (Refael Ackermann) #27375
  • [0a5ff4cb33] - (SEMVER-MAJOR) deps: V8: template explicit instantiation for GCC-8 (Refael Ackermann) #27375
  • [b411114a52] - (SEMVER-MAJOR) deps: V8: use ATOMIC_VAR_INIT instead of std::atomic_init (Refael Ackermann) #27375
  • [c08d94baef] - (SEMVER-MAJOR) deps: V8: forward declaration of Rtl\*FunctionTable (Refael Ackermann) #27375
  • [445bb81ab6] - (SEMVER-MAJOR) deps: V8: patch register-arm64.h (Refael Ackermann) #27375
  • [fa6dfec186] - (SEMVER-MAJOR) deps: V8: backport f89e555 (Michaël Zasso) #27375
  • [8b8fe87e54] - deps: V8: cherry-pick cca9ae3c9a (Benedikt Meurer) #27729
  • [55e99448c8] - (SEMVER-MAJOR) deps: V8: update postmortem metadata generation script (cjihrig) #26685
  • [2f92b15435] - (SEMVER-MAJOR) deps: V8: silence irrelevant warning (Michaël Zasso) #26685
  • [ca8e5aa77b] - (SEMVER-MAJOR) deps: V8: un-cherry-pick bd019bd (Refael Ackermann) #26685
  • [4a61bdbc1f] - (SEMVER-MAJOR) deps: V8: fix filename manipulation for Windows (Refael Ackermann) #27375
  • [86a8bb7612] - (SEMVER-MAJOR) deps: update V8 to 7.5.288.22 (Refael Ackermann) #27375
  • [071694472f] - dgram: fix abort on bad args (cjihrig) #28135
  • [ed8b9dc51d] - doc: revise intro sentence for assert (Rich Trott) #28226
  • [5b7b18d4df] - doc: improve assert strict-mode text (Rich Trott) #28239
  • [833d3d5ad1] - doc: clarify commit message format in pull-requests.md (rexagod) #28125
  • [f6b97f2aed] - doc: add missing options allowed in NODE_OPTIONS (Richard Lau) #28179
  • [37806839cf] - doc: document behavior of family:0 in dns.lookup() (cjihrig) #28163
  • [07ab5917f7] - doc: pass path in URL constructor (Daniel Nalborczyk) #28161
  • [41af9bfb24] - doc: update kernel and glibc reqs for PPCle (Michael Dawson) #28162
  • [abe5d05523] - (SEMVER-MINOR) doc: update assert's validation functions (Ruben Bridgewater) #27781
  • [ecb963dd44] - doc: document trace-events category for dns requests (vmarchaud) #28100
  • [8c277555b7] - doc: add Buffer#subarray() and add note about Uint8Array#slice() (FUJI Goro (gfx)) #28101
  • [4d6262fb56] - doc: update broken/foundation links in README.md (Tierney Cyren) #28119
  • [00e6c9d2dd] - doc: add tls-min/max options to NODE_OPTIONS (Daniel Bevenius) #28146
  • [705f259142] - doc: split example into two (Ruben Bridgewater) #27670
  • [69af43ead9] - doc: clarify N-API version Matrix (Michael Dawson) #27942
  • [56b150b3d7] - doc: add current recommendation for ESM/CommonJS dual packages (Geoffrey Booth) #27957
  • [360c708f64] - doc: document Http2Stream#id property (murgatroid99) #28074
  • [5fc4e48fdd] - doc: add note about AsyncResource for Worker pooling (Anna Henningsen) #28023
  • [d1c53fc54e] - doc: fix prohibited-strings warning in pull-requests.md (rexagod) #28127
  • [e6ecc13cfa] - doc: improve synopsis.md (Rich Trott) #28115
  • [eb05db907a] - doc: edit reason-for-deprecation text (Rich Trott) #28098
  • [5ad0d047c6] - doc: improve DEP0090 text (Rich Trott) #28097
  • [9074f9b4e5] - doc: clarify special schemes (Rich Trott) #28091
  • [f95a52cb1e] - doc: clarify weak keys text (Rich Trott) #28090
  • [eb73ed8158] - doc: remove superfluous filenaming convention (Rich Trott) #28089
  • [f7d8384af2] - doc: mark Node.js 11 as EOL in changelog (Richard Lau) #28076
  • [87c55ea0ef] - doc: adjust TOC margins (Roman Reiss) #28075
  • [9dd4813008] - doc: order deprecation reasons (Trivikram Kamat) #27960
  • [e3f905ac7e] - doc: remove "encouraged" as hedging in fs.md (Rich Trott) #28027
  • [df22b96cb0] - doc: remove "strongly recommended" as hedging in fs.md (Rich Trott) #28028
  • [049429bd97] - doc: remove "strongly recommended" hedging from tls.md (Rich Trott) #28029
  • [79d4f285be] - doc: remove "strongly recommended" hedging in deprecations.md (Rich Trott) #28031
  • [e36ed72855] - doc,n-api: fix typo (Richard Lau) #28178
  • [c574b57d65] - doc,test: test documentation consistency for NODE_OPTIONS (Richard Lau) #28179
  • [e89a39bbb7] - fs: document the Date conversion in Stats objects (Joyee Cheung) #28224
  • [d36adcdf34] - (SEMVER-MINOR) fs: add *timeNs properties to BigInt Stats objects (Joyee Cheung) #21387
  • [e1fc9b987a] - http2: do not register unnecessary listeners (Antonio Kukas) #27987
  • [53cc16c7dd] - https: do not automatically use invalid servername (Sam Roberts) #28209
  • [f8c9a58bf5] - inspector: added --inspect-publish-uid (Aleksei Koziatinskii) #27741
  • [ae7789a3c1] - module: prevent race condition while combining import and require (Ruben Bridgewater) #27674
  • [6014429580] - module: handle empty require.resolve() options (cjihrig) #28078
  • [83fc10dede] - n-api: define ECMAScript-compliant accessors on napi_define_class (legendecas) #27851
  • [d70fd7dddd] - n-api: define ECMAScript-compliant accessors on napi_define_properties (legendecas) #27851
  • [39063b3c00] - n-api: defer Buffer finalizer with SetImmediate (Anna Henningsen) #28082
  • [dfbbfbb765] - net: make writeAfterFIN() return false (Luigi Pinca) #27996
  • [44b0e13b1c] - perf_hooks,trace_events: use stricter equality (cjihrig) #28166
  • [50c803828f] - process: refactor unhandled rejection handling (Joyee Cheung) #28228
  • [b491eabff1] - process: improve queueMicrotask performance (Anatoli Papirovski) #28093
  • [460cc6285a] - process: code cleanup for nextTick (Anatoli Papirovski) #28047
  • [682105538a] - report: add cpu info to report output (Christopher Hiller) #28188
  • [7a4a94a54f] - src: fix compiler warning in node_worker.cc (Daniel Bevenius) #28198
  • [b9d21e5bfd] - src: fix off-by-one error in native SetImmediate (Anna Henningsen) #28082
  • [c67642ae03] - src: do not use pointer for loop in node_watchdog (Anna Henningsen) #28020
  • [b5dda32b8a] - src: restore stdio on program exit (Ben Noordhuis) #24260
  • [8984b73033] - src: remove TLS code for unsupported OpenSSLs (Sam Roberts) #28085
  • [8849eb24c1] - src: handle exceptions from ToDetailString() (Anna Henningsen) #28019
  • [8a032fc50c] - src: expose DOMException to internalBinding('message') for testing (Joyee Cheung) #28072
  • [a5fdedb3d5] - src: only run preloadModules if the preload array is not empty (Samuel Attard) #28012
  • [c821eefa5f] - src: add napi_define_class() null checks (Octavian Soldea) #27945
  • [95ee3b55d3] - src: use RAII in setgroups implementation (Anna Henningsen) #28022
  • [d81c67bd8f] - src: fix unused private field warning (cjihrig) #28036
  • [e8bedd2009] - src: split RunBootstrapping() (Joyee Cheung) #27539
  • [c20c6e55b5] - src: reorganize inspector and diagnostics initialization (Joyee Cheung) #27539
  • [c086736a49] - src: create Environment properties in Environment::CreateProperties() (Joyee Cheung) #27539
  • [70f8e71a0d] - src: inline ProcessCliArgs in the Environment constructor (Joyee Cheung) #27539
  • [edb1a3c3c1] - test: add eval ESM module tests (Evgenii Shchepotev) #27956
  • [42f5f27727] - test: fix NODE_OPTIONS feature check (Richard Lau) #28225
  • [720a2a6da3] - test: move --cpu-prof tests to sequential (Joyee Cheung) #28210
  • [6aa64517e5] - test: skip test-worker-prof as flaky for all (Milad Farazmand) #28175
  • [414e9d2811] - test: remove FIB environment variable from cpu-prof.js (Rich Trott) #28183
  • [066d814b3c] - test: remove unused output argument for getFrames() (Rich Trott) #28183
  • [5d8dce41e3] - test: document cpu-prof module (Rich Trott) #28183
  • [318328f6b7] - test: improve unexpected warnings error (Ruben Bridgewater) #28138
  • [31ccd36668] - test: mark test-fs-stat-bigint as flaky (Rich Trott) #28156
  • [de6627f9a4] - test: remove duplicate test-child-process-execfilesync-maxBuffer.js (Joyee Cheung) #28139
  • [2353c63dc2] - test: split test-cpu-prof.js (Joyee Cheung) #28170
  • [186e94c322] - test: add github refs to flaky tests (Sam Roberts) #28123
  • [d8061dc1a0] - test: remove test-gc-http-client from status file (Rich Trott) #28130
  • [d6791d1cb8] - test: remove test-tty-wrap from status file (Rich Trott) #28129
  • [b0bc23c572] - test: add comments to the foaf+ssl fixtures (Alex Aubuchon) #27962
  • [189d6af2b3] - test: change formatting of fixtures/keys/Makefile (Alex Aubuchon) #27962
  • [94a6d7a518] - test: change fixtures.readSync to fixtures.readKey (Alex Aubuchon) #27962
  • [c82023a173] - test: remove uneeded agent keypair in fixtures/ (Alex Aubuchon) #27962
  • [74e6109f39] - test: move foafssl certs to fixtures/keys/ (Alex Aubuchon) #27962
  • [78f39c91ac] - test: remove uneeded alice certs in fixtures/ (Alex Aubuchon) #27962
  • [5d0737735b] - test: remove uneeded certs in fixtures/ (Alex Aubuchon) #27962
  • [d757e0b6d4] - test: move dherror.pem to fixtures/keys/ (Alex Aubuchon) #27962
  • [f9ddcc6305] - test: remove pass-* certs (Alex Aubuchon) #27962
  • [e673b57055] - test: move test_[key|ca|cert] to fixtures/keys/ (Alex Aubuchon) #27962
  • [8670f6dd22] - test: move spkac certs to fixtures/keys/ (Alex Aubuchon) #27962
  • [7d1f15fba1] - test: move x448 keypairs to fixtures/keys/ (Alex Aubuchon) #27962
  • [22bbdc5068] - test: move ed448 keypairs to fixtures/keys/ (Alex Aubuchon) #27962
  • [9de9d55bfc] - test: move dsa keypairs to fixtures/keys/ (Alex Aubuchon) #27962
  • [9684842023] - test: move rsa keypairs to fixtures/keys/ (Alex Aubuchon) #27962
  • [7ae23abc01] - test: move x25519 keypair to fixtures/keys/ (Alex Aubuchon) #27962
  • [adb0197d6d] - test: move ed25519 keypair to fixtures/keys/ (Alex Aubuchon) #27962
  • [14bd26c8da] - test: remove workaround for unsupported OpenSSLs (Sam Roberts) #28085
  • [d4bb88eed8] - test: simplify tests code (himself65) #28065
  • [87e977ae42] - test: make sure vtable is generated in addon test with LTO (Anna Henningsen) #28057
  • [3feaf3ddbe] - test: mark test-worker-debug as flaky (Refael Ackermann) #28035
  • [098cf74292] - test: regression test tmpdir (Refael Ackermann) #28035
  • [e08a98fa43] - test: always suffix tmpdir (Refael Ackermann) #28035
  • [f33623662f] - test: shell out to rmdir first on Windows (Refael Ackermann) #28035
  • [1ef2811236] - test: only assert on first lines of TLS trace (Sam Roberts) #28043
  • [62de36e8d3] - Revert "test: move all test keys/certs under test/fixtures/keys/" (Sam Roberts) #28083
  • [2331e9c380] - test: add comments to the foaf+ssl fixtures (Alex Aubuchon) #27962
  • [8e28259bf8] - test: change formatting of fixtures/keys/Makefile (Alex Aubuchon) #27962
  • [d258504a31] - test: change fixtures.readSync to fixtures.readKey (Alex Aubuchon) #27962
  • [328b2d0c88] - test: remove uneeded agent keypair in fixtures/ (Alex Aubuchon) #27962
  • [a0d2862b1e] - test: move foafssl certs to fixtures/keys/ (Alex Aubuchon) #27962
  • [af9eb9648e] - test: remove uneeded alice certs in fixtures/ (Alex Aubuchon) #27962
  • [ee62fa172c] - test: remove uneeded certs in fixtures/ (Alex Aubuchon) #27962
  • [f41dfd71a0] - test: move dherror.pem to fixtures/keys/ (Alex Aubuchon) #27962
  • [98f7ae9e7b] - test: remove pass-* certs (Alex Aubuchon) #27962
  • [27d6b28943] - test: move test_[key|ca|cert] to fixtures/keys/ (Alex Aubuchon) #27962
  • [5ac6dddb83] - test: move spkac certs to fixtures/keys/ (Alex Aubuchon) #27962
  • [03b92e93b1] - test: move x448 keypairs to fixtures/keys/ (Alex Aubuchon) #27962
  • [4155bbaeab] - test: move ed448 keypairs to fixtures/keys/ (Alex Aubuchon) #27962
  • [9209698139] - test: move dsa keypairs to fixtures/keys/ (Alex Aubuchon) #27962
  • [ad42258d5a] - test: move rsa keypairs to fixtures/keys/ (Alex Aubuchon) #27962
  • [686cb13f78] - test: move x25519 keypair to fixtures/keys/ (Alex Aubuchon) #27962
  • [1f2de2fbe1] - test: move ed25519 keypair to fixtures/keys/ (Alex Aubuchon) #27962
  • [687e57fe19] - test: rename worker MessagePort test (Anna Henningsen) #28024
  • [7165254f8b] - test: more tls hostname verification coverage (Ben Noordhuis) #27999
  • [92d1ca9645] - (SEMVER-MAJOR) test: fail test-worker-prof on internal timeout (Refael Ackermann) #27375
  • [ab1a4eb12d] - (SEMVER-MAJOR) test: drain platform before unregistering isolate (Refael Ackermann) #27375
  • [b6bdf752d6] - test,v8: skip less and stabilize test-linux-perf.js (Refael Ackermann) #27364
  • [e270ff1166] - tls: remove unnecessary set of DEFAULT_MAX_VERSION (Daniel Bevenius) #28147
  • [6b9d477520] - tls: rename validateKeyCert in _tls_common.js (Daniel Bevenius) #28116
  • [90854124dd] - tools: assert that the snapshot can be rehashed in node_mksnapshot (Joyee Cheung) #28181
  • [a0c5b58b44] - tools: fix update-babel-eslint.sh script (Ruben Bridgewater) #27670
  • [6460d071d2] - tools: increase the maximum number of files to lint per worker (Ruben Bridgewater) #27670
  • [bf76823a47] - tools: ignore node_modules when linting (Ruben Bridgewater) #27670
  • [52564dbb28] - tools: update babel-eslint (Ruben Bridgewater) #27670
  • [9be67b2cbc] - tools: activate more eslint rules (Ruben Bridgewater) #27670
  • [739c2a3336] - tools: update eslint config (Ruben Bridgewater) #27670
  • [adfbd362fc] - tools: update eslint (Ruben Bridgewater) #27670
  • [018159d734] - (SEMVER-MAJOR) tools,gyp: introduce MSVS 2019 (Refael Ackermann) #27375
  • [9dd840dff5] - trace_events: respect inspect() depth (cjihrig) #28037
  • [225fb1bff7] - util: use average bias while grouping arrays (Ruben Bridgewater) #28070
  • [8f4bb1949f] - util: improve .inspect() array grouping (Ruben Bridgewater) #28070
  • [9ced334a6c] - util: refactor inspecting long lines (Ruben Bridgewater) #28055
  • [dfdf742fd1] - util: use Set to store deprecation codes (Daniel Nalborczyk) #28113
  • [c3243de47a] - util: special handle maxArrayLength while grouping arrays (Ruben Bridgewater) #28059
  • [f897860427] - util: support AsyncGeneratorFunction in .inspect (Ruben Bridgewater) #28056
  • [3611b471f7] - worker: refactor worker.terminate() (Anna Henningsen) #28021
  • [303a9a3d06] - worker: make MessagePort constructor non-callable (Anna Henningsen) #28032
  • [79a8cd0dec] - worker: add typechecking for postMessage transfer list (Anna Henningsen) #28033
  • [d7641d833c] - worker: use DataCloneError for unknown native objects (Anna Henningsen) #28025

refack and others added 30 commits June 4, 2019 18:44
Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Co-authored-by: Ujjwal Sharma <[email protected]>
Co-authored-by: Michaël Zasso <[email protected]>

Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Original commit message:

    [testrunner] delete ancient junit compatible format support

    Testrunner has ancient support for JUnit compatible XML output.

    This CL removes this old feature.

    [email protected],[email protected],[email protected]
    CC=​[email protected]

    Bug: v8:8728
    Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
    Reviewed-on: https://chromium-review.googlesource.com/c/1430065
    Reviewed-by: Jakob Gruber <[email protected]>
    Reviewed-by: Michael Starzinger <[email protected]>
    Commit-Queue: Tamer Tas <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#59045}

Refs: v8/v8@bd019bd

Backport-PR-URL: #28005
PR-URL: #26685
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Backport-PR-URL: #28005
PR-URL: #26685
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Update postmortem metadata constants for V8 7.5 in Node.js.

Backport-PR-URL: #28005
PR-URL: #26685
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Original commit message:

    Remove recursion from NeedsCheckHeapObject.

    We use the predicate NeedsCheckHeapObject in the compiler frontend to
    determine whether we can skip introducing CheckHeapObject nodes. But
    this predicate would also walk up the graph in case of Phis, which can
    result in really long compilation times (on the main thread). In the
    report in #27667, the compiler
    frontend alone took around 4-5mins of main thread time for a single
    function. With this patch the time goes down to 4-5ms.

    Bug: v8:9250
    Refs: #27667
    Change-Id: I231eb780ff04f949fa1669714f9af6ebfbcade05
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1612897
    Reviewed-by: Jaroslav Sevcik <[email protected]>
    Commit-Queue: Benedikt Meurer <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#61503}

Fixes: #27667

Backport-PR-URL: #28005
PR-URL: #27729
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Original commit message:

    [api] Fix compilation issue with macOS

    Fixes the following error caught by the Node.js CI:

    ../deps/v8/src/api.cc:8943:10:
      error: no viable conversion from returned value of type
      'unique_ptr<v8::internal::MicrotaskQueue, default_delete<v8::internal::MicrotaskQueue>>'
      to function return type
      'unique_ptr<v8::MicrotaskQueue, default_delete<v8::MicrotaskQueue>>'

      return microtask_queue;
             ^~~~~~~~~~~~~~~

    Change-Id: Ic09dab46bb8f87a2b3b59f5836e0883bfe0e9681
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627533
    Commit-Queue: Michaël Zasso <[email protected]>
    Commit-Queue: Yang Guo <[email protected]>
    Reviewed-by: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#61789}

Refs: v8/v8@f89e555

Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Fixes a compilation issue on some platforms

Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
This should be semver-patch since actual invocation is version
conditional.

Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
`std::atomic_init<size_t>` is not implemented in all platforms.

* pragma to ignore `-Wbraced-scalar-init`

Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Fails to link for missing:
void JSObject::ApplyAttributesToDictionary<NumberDictionary>(...)

Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Original commit message:

    Fixing a possible freeze on abort with 'v8_win64_unwinding_info'

    Win64 unwind data can specify a language-specific handler function which is
    called as part of the search for an exception handler, as described in
    https://docs.microsoft.com/en-us/cpp/build/exception-handling-x64?view=vs-2019.
    This is used for example by Crashpad to register its own exception handler for
    exceptions in V8-generated code.
    There is a problem in the code that may cause a freeze on abort: in file
    \deps\v8\src\unwinding-info-win64.cc in function CRASH_HANDLER_FUNCTION_NAME the
    line:
        return EXCEPTION_CONTINUE_SEARCH;
    should be
        return ExceptionContinueSearch;

    These constants are both used in the context of Win32 exception handlers, but
    they have different semantics and unfortunately different values:
    EXCEPTION_CONTINUE_SEARCH (=0) should be returned by an exception filter
    while a language-specific handler should return an EXCEPTION_DISPOSITION value,
    and more precisely ExceptionContinueSearch (=1) in this case.

    Bug: v8:9295
    Change-Id: I1a3aaabf357e52a909611814f1ea013cf652ae06
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1629795
    Reviewed-by: Jakob Kummerow <[email protected]>
    Commit-Queue: Paolo Severini <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#61867}

Refs: v8/v8@3a75c1f

Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Bump minimum version of ICU needed to build node to 64.

Refs: v8/v8@ccbe3d0

Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reverts v8/v8@1b51dca
Reverts v8/v8@1ab717d
Partially reverts v8/v8@b0077b3

PR-URL: #28005
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
This flag specifies how inspector websocket url should be reported.
Tthre options are supported:
- stderr - reports websocket as a message to stderr,
- http - exposes /json/list endpoint that contains inspector websocket
  url,
- binding - require('inspector').url().

Related discussion: nodejs/diagnostics#303

PR-URL: #27741
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Inline `ProcessCliArgs()` in the `Environment` constructor, and
emit the `Environment` creation trace events with the arguments
earlier. Remove the unused arguments passed to `CreateProcessObject()`
since these are now attached to process in `PatchProcessObject()`
during pre-execution instead.

PR-URL: #27539
Reviewed-By: Anna Henningsen <[email protected]>
Move creation of `env->as_callback_data()`, `env->primordials()`
and `env->process()` into `Environment::CreateProperties()` and
call it in the `Environment` constructor - this can be replaced with
deserialization when we snapshot the per-environment properties
after the instantiation of `Environment`.

PR-URL: #27539
Reviewed-By: Anna Henningsen <[email protected]>
- Split the initialization of the inspector and other diagnostics
  into `Environment::InitializeInspector()` and
  `Environment::InitializeDiagnostics()` - these need to be
  reinitialized separately after snapshot deserialization.
- Do not store worker url alongside the inspector parent handle,
  instead just get it from the handle.
- Rename `Worker::profiler_idle_notifier_started_` to
  `Worker::start_profiler_idle_notifier_` because it stores
  the state inherited from the parent env to use for initializing
  itself.

PR-URL: #27539
Reviewed-By: Anna Henningsen <[email protected]>
Split `RunBootstrapping()` into `BootstrapInternalLoaders()`
and `BootstrapNode()` from so the two can be snapshotted
incrementally.

PR-URL: #27539
Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #27954
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
If `false` is not returned a readable stream piped into the socket
might continue reading indefinitely until the process goes out of
memory.

PR-URL: #27996
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Add some additional tests that check the interaction of an IP address
as the Common Name and the presence (or lack of presence) of DNS, URI,
and IP Address Subject Alternative Names.

PR-URL: #27999
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
PR-URL: #28036
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR
Copy link
Member Author

@nodejs/releasers @nodejs/documentation please have a look at the notable changes.

@addaleax
Copy link
Member

This release contains semver-major commits. These are in fact, not "semver-major" due to follow-up patches that remove all breaking changes.

We should just not label them as semver-major in the changelog, imo… that’s just going to confuse people if we do that

BridgeAR added a commit that referenced this pull request Jun 26, 2019
Notable changes:

* build:
  * The startup time is reduced by enabling V8 snapshots by default
    #28181
* deps:
  * Updated `V8` to 7.5.288.22 #27375
    * The numeric separator (v8.dev/features/numeric-separators) feature is now
      enabled by default
  * Updated `OpenSSL` to 1.1.1c #28211
* inspector:
  * The `--inspect-publish-uid` flag was added to specify ways of the inspector
    web socket url exposure #27741
* n-api:
  * Accessors on napi_define_* are now ECMAScript-compliant
    #27851
* report:
  * The cpu info got added to the report output
    #28188
* src:
  * Restore the original state of the stdio file descriptors on exit to prevent
    leaving stdio in raw or non-blocking mode
    #24260
* tools,gyp:
  * Introduce MSVS 2019 #27375
* util:
  * inspect:
    * Array grouping became more compact and uses more columns than before
      #28059
      #28070
    * Long strings will not be split at 80 characters anymore. Instead they will
      be split on new lines #28055
* worker:
  * `worker.terminate()` now returns a promise and using the callback is
    deprecated #28021

PR-URL: #28268
@BridgeAR
Copy link
Member Author

@addaleax I removed the comment from the notable changes as suggested.

@BridgeAR
Copy link
Member Author

There was an error while building the Node binaries and I have to rebuild them. @nodejs/releasers it would be good to get a review before the actual release.

@targos
Copy link
Member

targos commented Jun 26, 2019

Unfortunately the date is wrong in the commit message. I don't know if that's important enough to rebuild everything

BridgeAR added a commit that referenced this pull request Jun 26, 2019
Notable changes:

* build:
  * The startup time is reduced by enabling V8 snapshots by default
    #28181
* deps:
  * Updated `V8` to 7.5.288.22 #27375
    * The numeric separator (v8.dev/features/numeric-separators) feature is now
      enabled by default
  * Updated `OpenSSL` to 1.1.1c #28211
* inspector:
  * The `--inspect-publish-uid` flag was added to specify ways of the inspector
    web socket url exposure #27741
* n-api:
  * Accessors on napi_define_* are now ECMAScript-compliant
    #27851
* report:
  * The cpu info got added to the report output
    #28188
* src:
  * Restore the original state of the stdio file descriptors on exit to prevent
    leaving stdio in raw or non-blocking mode
    #24260
* tools,gyp:
  * Introduce MSVS 2019 #27375
* util:
  * inspect:
    * Array grouping became more compact and uses more columns than before
      #28059
      #28070
    * Long strings will not be split at 80 characters anymore. Instead they will
      be split on new lines #28055
* worker:
  * `worker.terminate()` now returns a promise and using the callback is
    deprecated #28021

PR-URL: #28268
@BridgeAR
Copy link
Member Author

@targos thanks. I just updated it. Since the last build failed and I just restarted a new build just a half an hour before, I stopped the build and build the release with the correct date.

PTAL

@targos
Copy link
Member

targos commented Jun 26, 2019

LGTM

@BridgeAR
Copy link
Member Author

@nodejs/build please take a look at the release builds. Two builds failed so far with different targets failing (https://ci-release.nodejs.org/job/iojs+release/4520/ and https://ci-release.nodejs.org/job/iojs+release/4522). The CI seems fine though.

This blocks the current release.

@rvagg
Copy link
Member

rvagg commented Jun 27, 2019

first one is just some network connectivity problem on osx

07:37:08 ssh: connect to host direct.nodejs.org port 22: Operation timed out

second one is less innocuous on win:

13:45:54 MSBUILD : error MSB4166: Child node "2" exited prematurely. Shutting down. Diagnostic information may be found in files in "C:\Users\Administrator\AppData\Local\Temp\1" and will be named MSBuild_*.failure.txt. This location can be changed by setting the MSBUILDDEBUGPATH environment variable to a different directory.

but without repeats of this I'd put it down to a temporary glitch on the machine (also, those MSBuild_*.failure.txt files weren't in that directory so I don't know what it's talking about).

In this case, where you're having problems that are completely unrelated, just try again. I know it would be nice if it always just worked but there's so many moving parts here that it's not surprising that things occasionally break. But without a pattern that points to something fundamentally broken, just try again and see if a pattern emerges.

I've done a rebuild of 4522's parameters in: https://ci-release.nodejs.org/job/iojs+release/4523/, let's see how that goes.

The other thing to note here is that if you used the same parameters across both runs and your failures were on different targets, you actually got all the built assets in staging that you needed and could go ahead and promote what's there. They should all cover the same release commit. Caution isn't a bad thing of course so if you don't feel confident then holding it up for an all-green is a reasonable approach.

@rvagg
Copy link
Member

rvagg commented Jun 27, 2019

https://ci-release.nodejs.org/job/iojs+release/4523/ was all green btw, just run release.sh and it should be good to go

Notable changes:

* build:
  * The startup time is reduced by enabling V8 snapshots by default
    #28181
* deps:
  * Updated `V8` to 7.5.288.22 #27375
    * The numeric separator (v8.dev/features/numeric-separators) feature is now
      enabled by default
  * Updated `OpenSSL` to 1.1.1c #28211
* inspector:
  * The `--inspect-publish-uid` flag was added to specify ways of the inspector
    web socket url exposure #27741
* n-api:
  * Accessors on napi_define_* are now ECMAScript-compliant
    #27851
* report:
  * The cpu info got added to the report output
    #28188
* src:
  * Restore the original state of the stdio file descriptors on exit to prevent
    leaving stdio in raw or non-blocking mode
    #24260
* tools,gyp:
  * Introduce MSVS 2019 #27375
* util:
  * inspect:
    * Array grouping became more compact and uses more columns than before
      #28059
      #28070
    * Long strings will not be split at 80 characters anymore. Instead they will
      be split on new lines #28055
* worker:
  * `worker.terminate()` now returns a promise and using the callback is
    deprecated #28021

PR-URL: #28268
@BridgeAR BridgeAR merged commit 01b404f into v12.x Jun 27, 2019
BridgeAR added a commit that referenced this pull request Jun 27, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jun 27, 2019
Notable changes:

* build:
  * The startup time is reduced by enabling V8 snapshots by default
    nodejs#28181
* deps:
  * Updated `V8` to 7.5.288.22 nodejs#27375
    * The numeric separator (v8.dev/features/numeric-separators) feature is now
      enabled by default
  * Updated `OpenSSL` to 1.1.1c nodejs#28211
* inspector:
  * The `--inspect-publish-uid` flag was added to specify ways of the inspector
    web socket url exposure nodejs#27741
* n-api:
  * Accessors on napi_define_* are now ECMAScript-compliant
    nodejs#27851
* report:
  * The cpu info got added to the report output
    nodejs#28188
* src:
  * Restore the original state of the stdio file descriptors on exit to prevent
    leaving stdio in raw or non-blocking mode
    nodejs#24260
* tools,gyp:
  * Introduce MSVS 2019 nodejs#27375
* util:
  * inspect:
    * Array grouping became more compact and uses more columns than before
      nodejs#28059
      nodejs#28070
    * Long strings will not be split at 80 characters anymore. Instead they will
      be split on new lines nodejs#28055
* worker:
  * `worker.terminate()` now returns a promise and using the callback is
    deprecated nodejs#28021

PR-URL: nodejs#28268
BridgeAR added a commit to BridgeAR/nodejs.org that referenced this pull request Jun 27, 2019
BridgeAR added a commit to nodejs/nodejs.org that referenced this pull request Jun 27, 2019
@targos targos deleted the v12.5.0-proposal branch June 27, 2019 15:36
@targos targos added release Issues and PRs related to Node.js releases. and removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory. labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.