Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Update node-inspect to v1.11.6 #28039

Closed
wants to merge 1 commit into from
Closed

deps: Update node-inspect to v1.11.6 #28039

wants to merge 1 commit into from

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented Jun 3, 2019 •
edited
Loading

Highlights

  • The node-inspect test suite passes against latest master.
  • Removes use of deprecated repl.rli.

Compare: nodejs/node-inspect@v1.11.5...v1.11.6

Generated via:

rm -rf deps/node-inspect node-inspect-* && curl -sSL "https://github.com/nodejs/node-inspect/archive/v1.11.6.tar.gz" | tar -xzvf - && mv node-inspect-* deps/node-inspect

Rendered Changelog

1.11.6

Checklist
  • make test-node-inspect passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@jkrems jkrems added the debugger label Jun 3, 2019
deps: update node-inspect to v1.11.6
fa14ff6 
Highlights:

* The `node-inspect` test suite passes against latest master.
* Removes use of deprecated `repl.rli`.

Compare: nodejs/node-inspect@v1.11.5...v1.11.6
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23603/

@jkrems jkrems self-assigned this Jun 5, 2019
jkrems pushed a commit that referenced this pull request Jun 5, 2019
@jkrems
deps: update node-inspect to v1.11.6
6a7d3ca 
Highlights:

* The `node-inspect` test suite passes against latest master.
* Removes use of deprecated `repl.rli`.

Compare: nodejs/node-inspect@v1.11.5...v1.11.6

PR-URL: #28039
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@jkrems
Copy link
Contributor Author

jkrems commented Jun 5, 2019

Landed in 6a7d3ca

@jkrems jkrems closed this Jun 5, 2019
@jkrems jkrems removed their assignment Jun 5, 2019
@jkrems jkrems deleted the node-inspect-v1.11.6 branch June 5, 2019 15:24
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@BridgeAR
deps: update node-inspect to v1.11.6
d42ad64 
Highlights:

* The `node-inspect` test suite passes against latest master.
* Removes use of deprecated `repl.rli`.

Compare: nodejs/node-inspect@v1.11.5...v1.11.6

PR-URL: #28039
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
@jkrems jkrems mentioned this pull request Aug 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jkrems @nodejs-github-bot @targos @cjihrig @gengjiawen @BridgeAR @trivikr @ZYSzys