Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove "encouraged" as hedging in fs.md #28027

Closed
wants to merge 1 commit into from
Closed

doc: remove "encouraged" as hedging in fs.md #28027

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 2, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
Copy link
Member Author

Trott commented Jun 2, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3644/

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. labels Jun 2, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Jun 5, 2019

Landed in 1279e25.

@ZYSzys ZYSzys closed this Jun 5, 2019
ZYSzys pushed a commit that referenced this pull request Jun 5, 2019
@Trott @ZYSzys
doc: remove "encouraged" as hedging in fs.md
1279e25 
PR-URL: #28027
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@Trott @BridgeAR
doc: remove "encouraged" as hedging in fs.md
e3f905a 
PR-URL: #28027
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
@Trott Trott deleted the strongly-recommended branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @ZYSzys @targos @cjihrig @BridgeAR @trivikr