Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve synopsis.md #28115

Merged
merged 1 commit into from
Jun 9, 2019
Merged

doc: improve synopsis.md #28115

merged 1 commit into from
Jun 9, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 7, 2019

Many small improvements to synopsis.md to make it more concise, more
clear, and more correct (punctuation, etc.).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 7, 2019
@Trott
Copy link
Member Author

Trott commented Jun 7, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3657/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 7, 2019
@Trott
doc: improve synopsis.md
7105bbc 
Many small improvements to synopsis.md to make it more concise, more
clear, and more correct (punctuation, etc.).

PR-URL: nodejs#28115
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 9, 2019

Landed in 7105bbc

@Trott Trott merged commit 7105bbc into nodejs:master Jun 9, 2019
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@Trott @BridgeAR
doc: improve synopsis.md
e6ecc13 
Many small improvements to synopsis.md to make it more concise, more
clear, and more correct (punctuation, etc.).

PR-URL: #28115
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
@Trott Trott deleted the copyedit-synopsis branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @danbev @lpinca @cjihrig @BethGriggs @trivikr