build: unbreak --with-intl=system-icu build

Include directories are configured by the tools/icu/icu-*.gyp files. The v8.gyp file doesn't need to add them and in fact the way it did that breaks when building against an external copy of ICU. Fixes: #28052 PR-URL: #28118 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jun 17, 2019 · 7d0ffee · 7d0ffee
1 parent 0931f7e
commit 7d0ffee
Showing 1 changed file with 0 additions and 7 deletions.
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
@@ -393,13 +393,6 @@
             '<(icu_gyp_path):icui18n',
             '<(icu_gyp_path):icuuc',
           ],
-          'direct_dependent_settings': {
-            'include_dirs': [
-              '<(icu_path)/source/common',
-              '<(icu_path)/source/i18n',
-              '<(icu_path)/source/tools/toolutil',
-            ],
-          },
         }],
       ],
     },  # v8_maybe_icu