http2: Prevent unnecessary listeners from being registered #27987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
reviewed
May 30, 2019
addaleax
approved these changes
May 31, 2019
Update symbol description to match the name. Initialize field in the constructor. Reset field instead of deleting it.
BridgeAR
approved these changes
May 31, 2019
BridgeAR
added
the
author ready
jasnell
approved these changes
Jun 10, 2019
|
Landed in bcf1135 |
addaleax
pushed a commit
that referenced
this pull request
Jun 10, 2019
PR-URL: #27987 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
PR-URL: #27987 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple requests are started on a client HTTP/2 session while it it still connecting, a warning might get emitted:
MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 connect listeners added to Http2SessionThis PR modifies the offending code so that only one event listener is registered, no matter how many requests are started. A test for the fix is included.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes