module: handle empty require.resolve() options

If require.resolve() is passed an options object, but the paths option is not present, then use the default require.resolve() paths. PR-URL: #28078 Fixes: #28077 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jun 17, 2019 · 6014429 · 6014429
1 parent a0c5b58
commit 6014429
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
@@ -599,7 +599,9 @@ Module._resolveFilename = function(request, parent, isMain, options) {
           }
         }
       }
-    } else if (options.paths !== undefined) {
+    } else if (options.paths === undefined) {
+      paths = Module._resolveLookupPaths(request, parent);
+    } else {
       throw new ERR_INVALID_OPT_VALUE('options.paths', options.paths);
     }
   } else {

diff --git a/test/fixtures/require-resolve.js b/test/fixtures/require-resolve.js
@@ -92,3 +92,9 @@ common.expectsError(() => {
   code: 'ERR_INVALID_OPT_VALUE',
   type: TypeError,
 });
+
+// Verify that the default require.resolve() is used for empty options.
+assert.strictEqual(
+  require.resolve('./printA.js', {}),
+  require.resolve('./printA.js')
+);