v6.10.3 proposal #12498
Merged
v6.10.3 proposal #12498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original Commit Message: PR-URL: #11872 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Backport-Of: #11872 PR-URL: #11943 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #11943 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #11670 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
These changes result in ~50% improvement in the included benchmark. PR-URL: #10580 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Backport-PR-URL: #11775 PR-URL: #10685 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Manually fix issues that eslint --fix couldn't do automatically. Backport-PR-URL: #11775 PR-URL: #10685 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
* Change var to const in an example of server creation. * Add missing semicolons. * Use `console` syntax highlighting in `telnet` and `nc` invocation examples and add shell prompt symbols to be consistent with the rest of the documentation. Backport-PR-URL: #11969 PR-URL: #11786 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Even though arrow functions and ES5 anonymous functions are technically the same for util.js, it won't hurt to test both. Backport-PR-URL: #11970 PR-URL: #11781 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Backport-PR-URL: #12173 PR-URL: #11095 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
This cherry-picks the changes to `configure` from commit 8f00455 ("inspector: switch to new inspector APIs") from the master branch and should unbreak `--without-ssl` builds. Refs: #12155 PR-URL: #12200 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Unlike all the other tls APIs, if any secure context configuration is required, the caller is responsible for creating the context. Corrects a doc regression introduced in caa7fa9. PR-URL: #10545 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
* Clarify that memory is always shared and never copied. * Fix wording that sounded like ArrayBuffer has a buffer property. PR-URL: #10778 Ref: #10770 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
* use const and let instead of var * use common.mustCall to control functions execution * use assert.ifError instead of assert.strictEqual for errors * use arrow functions PR-URL: #10542 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #10577 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use assert.strictEqual instead of assert.equal in tests, manually convert types where necessary. Backport-PR-URL: #11795 PR-URL: #10698 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Teddy Katz <[email protected]>
Extend no-restricted-properties to catch use of assert.equal() and assert.notEqual() and require assert.strictEqual() or assert.notStrictEqual() instead. Also update the eslint-ignore in lib/assert.js to avoid assert.equal/notEqual linter errors in their definitions. Backport-PR-URL: #11795 PR-URL: #10698 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Teddy Katz <[email protected]>
Use common.mustCall() where appropriate, var to const/let, assert.equal() -> assert.strictEqual(), explicit time provided to setTimeout() Backport-PR-URL: #11797 PR-URL: #10551 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Some systems may have multiple group names with the same group ID, in which case getgroups() returns duplicate values, where `id -G` will filter the duplicates. Unique and sort the arrays so they can be compared. Backport-PR-URL: #12468 PR-URL: #10389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Backport-PR-URL: #12468 PR-URL: #10389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Backport-PR-URL: #12468 PR-URL: #10389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Docs referred to an `issuer` property being optionally present, when it should have referred to the `issuerCertificate` property. Backport-PR-URL: #12468 PR-URL: #10389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
SecureContext.addCACert() adds to the existing root store, preserving root cert entries. option.ca is applied without calling SecureContext.addRootCerts() so should add to the default, empty, root store. This test confirms that the built-in root CAs are not included when options.ca is used. Based on: shigeki@acd5837 Backport-PR-URL: #12468 PR-URL: #10389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
TLS connection setup boilerplate is common to many TLS tests, factor it into a test fixture so tests are clearer to read and faster to write. Backport-PR-URL: #12468 PR-URL: #10389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This adds a missing Returns to os.arch() as well as a missing added in version to os.constants. PR-URL: #10994 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #11615 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #11518 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #11625 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
The `common.skip` function adds proper message in TAP format to skipped tests. It is better not to have the message rewritten in the tests. PR-URL: #11585 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
* add semicolons in examples * fix indentation in code example * add spaces in code examples * console.log() -> console.error() * fix level of headings * update comment code example * delete obsolete info and example Fixes: #11558 PR-URL: #11566 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The allowHalfOpen comment was added in commit 8a3befa ("net: Refactor to use streams2") from 2012 but it wasn't true even then as far as I can tell: Node.js simply always does a shutdown(2) first. It is true that streams2 withholds the 'end' event when allowHalfOpen is true but the comment is about a callback that hangs off the 'finish' event that is emitted after calling `socket.end()`. PR-URL: #11573 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
@sam-github how did you generate this list? Most of those have not landed for a variety of reasons
FWIW it is not important that EVERYTHING that can backport makes it to each release, more so that we make a good effort to land them. Please feel free to audit your list and land anything that obviously should land. Randomly clicking on handful had them all in one of the states of LTS-purgatory, perhaps we need a label for things in that stage to filter |
|
@MylesBorins I forgot to exclude the backport-requested, oops. Updated: So, I think what's left either should land or is not yet labelled. I know many of the PRs have comments from you asking if they should land ("LTS purgatory"), so they are not yet labelled as to their disposition because its unknown. Maybe a label for that would be useful, maybe that's what |
|
@sam-github that's what I've been using LTS watch for... fwiw now that I've cut the RC I do not plan to backport anything else unless it is an obvious bug or fix. We can start landing other stuff in staging once the release goes out |
PR-URL: #11286 Fixes: #11244 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ron Korving <[email protected]>
#11863 adds _O_RDWR to node.cc which is defined in fcntl.h. This adds this include directly to node.cc. PR-URL: #12540 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
This commit adds lldbinit files from upstream V8 and also adds these so
that they get installed when `make install` is run.
Original commit message:
[tools] add lldbinit
The goal of this commit is to add the equivalent to gdbinit but
for lldb. I've tried to replicate the commands as close as possible
but I'm unsure about the jss command and hoping to get some feedback
on it in addition to the bta command which I'm not sure how/when
this could be used. This is probably just inexperience on my part.
The lldbinit file can be placed into a directory prefixed with dot
(.lldbinit) and the python script is currently expected to be in the
same directory. The path to the script can be changed manually if
needed as well.
NOTRY=true
Review-Url: https://codereview.chromium.org/2758373002
Cr-Commit-Position: refs/heads/master@{#44136}
PR-URL: #12061
Reviewed-By: Ben Noordhuis <[email protected]>
* Replace `var` by `const`. * Fix semicolons. * Add missing code marks. * Unify quotes. * Comment out ellipsis. * Use object destructuring. * Replace snake_case by camelCase. Backport-PR-URL: #12500 PR-URL: #12224 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
Also allows someone to reassign `$RM`, e.g. with `RM=rm -v` instead of `rm -f` (the default) should they want to. We're currently using a mixture of `$(RM)` and `rm -f`. There are a couple of places which aren't doing -f, have them do it for consistency. Backport-PR-URL: #12515 PR-URL: #12157 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Original commit message:
Don't treat catch scopes as possibly-shadowing for sloppy eval
Scope analysis is over-conservative when treating variable
resolutions as possibly-shadowed by a sloppy eval. In the attached
bug, this comes into play since catch scopes have different behavior
with respect to the "calls eval" in eager vs lazy compilation (in
the latter, they are never marked as "calls eval" because
CatchContexts don't have an associated ScopeInfo).
This patch changes the scope-type check to also eliminate a few
other cases where shadowing isn't possible, such as non-declaration
block scopes.
BUG=chromium:608279
LOG=n
Committed:
https://crrev.com/75f2d65f003ebb22815489e9970913ba37234f1b
Cr-Commit-Position: refs/heads/master@{#36046}
Fixes: #12308
PR-URL: #12535
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins
force-pushed
the
v6.10.3-proposal
branch
from
21b1929
to
0440447
Compare
Change var to const/let. Simplify test-timers-uncaught-exception. Backport-PR-URL: #12401 PR-URL: #10524 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins
force-pushed
the
v6.10.3-proposal
branch
from
0440447
to
d90a948
Compare
MylesBorins
added a commit
that referenced
this pull request
Apr 24, 2017
Notable Changes: Coming Soon PR-URL: #12498
|
ci: https://ci.nodejs.org/job/node-test-pull-request/7650/ rc.1: https://nodejs.org/download/rc/v6.10.3-rc.1/ edit: CI is looking good but we have an absurd amount of failures on citgm |
|
citgm issue addressed @ nodejs/citgm#399 |
|
One more run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/744/ thanks @gibfahn |
This reverts commit 587857e. It was found to have subtle behavior changes in deleting objects. PR-URL: #12721 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins
force-pushed
the
v6.10.3-proposal
branch
from
d90a948
to
9ecb9e0
Compare
MylesBorins
added a commit
that referenced
this pull request
Apr 29, 2017
Notable Changes: Coming Soon PR-URL: #12498
|
Review of failures ubuntu1604-64
fedora 22:
fedora 23
To Be Continued in an edit |
|
One more for prosperity https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/755/ |
|
All CITGM failures are expected. @nodejs/build as mentioned in other thread we should get to the bottom of the inconsistent failures with uglify |
Notable Changes:
* module:
- The module loading global fallback to the Node executable's
directory now works correctly on Windows.
(Richard Lau) #9283
* src:
- fix base64 decoding in rare edgecase
(Nikolai Vavilov) #11995
* tls:
- fix rare segmentation faults when using TLS
* (Trevor Norris) #11947
* (Ben Noordhuis) #11898
* (jBarz) #11776
PR-URL: #12497
MylesBorins
force-pushed
the
v6.10.3-proposal
branch
from
9ecb9e0
to
a0bfd4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017-05-02, Version 6.10.3 'Boron' (LTS), @MylesBorins
Notable Changes
Coming Soon
Commits
858bbaa4aa] - Partial revert "tls: keep track of stream that is closed" (Trevor Norris) #1194712c0ce749f] - assert, tools: enforce strict (not)equal in eslint (Gibson Fahnestock) #10698abbf6e38f1] - benchmark: fix fs\bench-realpathSync.js (Vse Mozhet Byt) #1190453d7a89497] - buffer: remove unneeded eslint-disable comment (Rich Trott) #119065d74c9e749] - buffer: refactor Buffer.prototype.inspect() (Rich Trott) #11600e7e83f6f10] - build: use $(RM) in Makefile for consistency (Gibson Fahnestock) #12157986ef6fffa] - build: add checks for openssl configure options (Daniel Bevenius) #12175c2c467e242] - build: make configure print statements consistent (Daniel Bevenius) #121762c2a6649c1] - build: add node_use_openssl check to install.py (Daniel Bevenius) #11766a899b0b92b] - build: fix llvm version detection in freebsd-10 (Shigeki Ohtsu) #11668ba23506419] - build: --without-ssl implies --without-inspector (Ben Noordhuis) #12200cd78a2bd07] - deps: backport 75f2d65f00 from upstream V8 (Yang Guo) #1253562e047e040] - deps: backport ec1ffe3 from upstream V8 (Daniel Bevenius) #120618cdddcdb68] - deps: cherry-pick ca0f9573 from V8 upstream (Ali Ijaz Sheikh) #11940d15188f6e2] - doc: modernize and fix code examples in modules.md (Vse Mozhet Byt) #1222403f9388eb7] - doc: clarify out-of-bounds behavior of buf[index] (Nikolai Vavilov) #11286eddfd5230e] - doc: add refack to collaborators (Refael Ackermann) #1227722af92ac2e] - doc: add richardlau to collaborators (Richard Lau) #120208d1a474ec2] - doc: fix confusing example in process.md (Vse Mozhet Byt) #1228288f402c4c1] - doc: update information on test/known_issues (Jan Krems) #1226234f9dfde1f] - doc: fix confusing reference in net.md (Vse Mozhet Byt) #122477e67176d79] - doc: document the performance team (Gibson Fahnestock) #122133b38e7109f] - doc: add aqrln to collaborators (Alexey Orlenko) #12273811ccdf06a] - doc: modernize and fix code examples in https.md (Vse Mozhet Byt) #12171c0d9b1c02b] - doc: fix string interpolation in Stream 'finish' (Vinay Hiremath) #12221f4dd304c32] - doc: add table of contents to README.md (Jason Marsh) #11635d007427c63] - doc: add logo to README (Roman Reiss) #121489dda771c1f] - doc: update and modernize examples in fs.ms (Vse Mozhet Byt) #1203581f561bed8] - doc: stdout/err/in are all Duplex streams (Sebastian Van Sande) #1119497035136d6] - doc: fix process.stdout fd number (Fumiya KARASAWA) #12055aab9526d69] - doc: update collaborator email address (Rich Trott) #119966885dccd3d] - doc: correct info in child_process.md (Vse Mozhet Byt) #11949fb0a2e426d] - doc: remove superfluous sample assert code (Rich Trott) #119333ad0a1430d] - doc: require uses fs root for '/' prefix (Bradley Farias) #11897d149844b49] - doc: fix gitter badge in README (Roman Reiss) #119444a97bc7a39] - doc: add missing word in stream.md (Jyotman Singh) #11914f53c48e173] - doc: add vsemozhetbyt to collaborators (Vse Mozhet Byt) #11932c10a4a2a7a] - doc: add note that vm module is not a security mechanism (Ruslan Bekenev) #11557b8e3a5f109] - doc: fix a typo in api/process.md (Gaara) #11780463f29413b] - doc: correct comment error in stream.md (Alexander) #118048a521fe0dc] - doc: var -> let / const in events.md (Vse Mozhet Byt) #11810331c0a8a26] - doc: console.log() -> console.error() in events.md (Vse Mozhet Byt) #1181082d2f13680] - doc: update to current V8 versions (Franziska Hinkelmann) #11787be537d0062] - doc: package main can be directory with an index (Bradley Farias) #115810e13887421] - doc: reduce font size on smaller screens (Gibson Fahnestock) #116950acebb985f] - doc: fix occurences of "the the" (Jeroen Mandersloot) #117118de856b191] - doc: fix process links to console.log/error (Sam Roberts) #1171812760339dc] - doc: add Franziska Hinkelmann to the CTC (Rod Vagg) #11488e8f0dba3af] - doc: fixed readable.isPaused() version annotation (Laurent Fortin) #1167740b27ba8bb] - doc: remove Locked from stability index (Rich Trott) #1166170a6a0a918] - doc: unlock module (Rich Trott) #11661e02d724273] - doc: fix misleading ASCII comments (Rahat Ahmed) #116573419b7a9d4] - doc: addDaijiro Wachito collaborators (Daijiro Wachi) #11676a042c8a0ef] - doc: fix typo in stream doc (Bradley Curran) #11560c0663e51d1] - doc: fixup errors.md (Vse Mozhet Byt) #115660aab0503be] - doc: add link to references in net.Socket (Joyee Cheung) #11625109fd72f11] - doc: use common malformed instead of misformatted (James Sumners) #115186c3b104548] - doc: fix typo in STYLE_GUIDE.md (Nikolai Vavilov) #11615c9b302b96e] - doc: make os api doc more consistent (Evan Lucas) #10994cbfc3fcd9d] - doc: use correct tls certificate property name (Sam Roberts) #103894fd765eec8] - doc: clarify memory sharing behavior of buffer ctor (Zach Bjornson) #10778c138ba3684] - doc: new TLSSocket has no secure context options (Sam Roberts) #1054516048480e7] - doc: fix stylistic issues in api/net.md (Alexey Orlenko) #11786de22ff642f] - doc: fix broken URL to event loop guide (Poker) #116700dfb9daa04] - doc: add supported platforms list for v6.x (Michael Dawson) #11943b9766bdd1b] - doc: add supported platforms list (Michael Dawson) #11943f1c2f2675c] - doc,test: tls .ca option supports multi-PEM files (Sam Roberts) #103891158f44599] - events,test: fix TypeError in EventEmitter warning (jseagull) #90210fff04f24f] - lib: add comment to script eval _tickCallback (Gibson Fahnestock) #120501a7d6337fb] - lib: fix event race condition with -e (Ben Noordhuis) #11958f8426d9177] - lib: remove unused msg parameter in debug_agent (mr-spd) #11833e3105cf50a] - meta: move WORKING_GROUPS.md to CTC repo (James M Snell) #11555f0288f3969] - meta: remove out of date ROADMAP.md file (James M Snell) #11556500d17b071] - module: fix loading from global folders on Windows (Richard Lau) #928306752d1fc0] - net: remove misleading comment (Ben Noordhuis) #11573bed6acb1ed] - Revert "src: fix delete operator on vm context" (Myles Borins) #12721c667e6e083] - src: add fcntl.h include to node.cc (Bartosz Sosnowski) #125401a63321dbf] - src: fix base64 decoding (Nikolai Vavilov) #119951434e7ff11] - src: ensure that fd 0-2 are valid on windows (Bartosz Sosnowski) #118631035967989] - src: remove outdated FIXME in node_crypto.cc (Daniel Bevenius) #11669c33933eb6d] - src, buffer: do not segfault on out-of-range index (Timothy Gu) #11927f9287461dd] - stream: avoid additional validation for Buffers (Brian White) #10580457c47d85e] - stream_base,tls_wrap: notify on destruct (Trevor Norris) #11947aae3765e6f] - test: refactor several parallel/test-timer tests (Beth Griggs) #105248c922736d0] - test: add a second argument to assert.throws() (dave-k) #12139a30ae72350] - test: skip irrelevant test on Windows (Rich Trott) #1226149ee30b8ac] - test: more robust check for location ofnode.exe(Refael Ackermann) #12120a93eaa4b2c] - test: performance, remove Popen(shell=True) on Win (Refael Ackermann) #121385f928a85e5] - test: increase querystring coverage (DavidCai) #121637af87384bc] - test: fix flaky test-child-process-exec-timeout (Santiago Gimeno) #121594caae6924f] - test: reduce buffer size in buffer-creation test (Sakthipriyan Vairamani (thefourtheye)) #11177eb19acb84e] - test: fix misleading comment (Franziska Hinkelmann) #12048e2279e297a] - test: fix broken tests in test-buffer-includes (Alexey Orlenko) #12040cddc32c954] - test: replace throw with common.fail (Dejon "DJ" Gill) #9700f23377c82d] - test: test validity of prefix in mkdtempSync (Luca Maraschi) #12009c65de59f52] - test: add regex for expected error message (John F. Mercer) #12011fcc19e1637] - test: add second argument to assert.throws() (Rj Bernaldo) #12016b69cac72e4] - test: refactor test-cluster-disconnect (Rich Trott) #119814cb4803db2] - test: add coverage for child_process bounds check (Rich Trott) #118002ee2cc6907] - test: refactor test-cli-eval.js (cjihrig) #10898b6c30e14fc] - test: fix broken assertion (cjihrig) #108404d6b484cf4] - test: refactor test-cli-eval.js (Sumit Goel) #1075931dea5c319] - test: invalid chars in http client path (Luca Maraschi) #119646063a4ac17] - test: improve test-vm-cached-data.js (Nick Peleh) #1197438017905d6] - test: add test for child_process.execFile() (Rich Trott) #11929485bb1b334] - test: fix flaky test-tls-socket-close (Rich Trott) #119219dd918b0ab] - test: fix assertion in vm test (AnnaMag) #118628e5c8a3ac1] - test: failing behaviour on sandboxed Proxy (AnnaMag) #1167172710d05b9] - test: fix flaky test-domain-abort-on-uncaught (Rich Trott) #1181746b2e45b40] - test: added test for indexed properties (AnnaMag) #11769a3f327fd21] - test: add regex to assert.throws (Matej Krajčovič) #118154d916da0d7] - test: fail when child dies in fork-net (Joyee Cheung) #116847d4941f01a] - test: fix args in parallel/test-fs-null-bytes.js (Vse Mozhet Byt) #11601cd98f5d303] - test: fix flaky test-http-set-timeout-server (Santiago Gimeno) #1179067b6d7d123] - test: add test for loading from global folders (Richard Lau) #9283aa9815081d] - test: add script to create 0-dns-cert.pem (Shigeki Ohtsu) #115795a93eab30d] - test: increase coverage of console (DavidCai) #116534befdd1c13] - test: limit lint rule disabling in message test (Rich Trott) #1172491b8da67a5] - test: skip the test with proper TAP message (Sakthipriyan Vairamani (thefourtheye)) #11584a43aa0eaa9] - test: changed test1 of test-vm-timeout.js (maurice_hayward) #115901b4f69acae] - test: remove obsolete eslint-disable comment (Rich Trott) #116437cc4645b70] - test: fix tests when npn feature is disabled. (Shigeki Ohtsu) #1165596924ed8f5] - test: add test-buffer-prototype-inspect (Rich Trott) #11600a27098d921] - test: enable max-len for test-repl (Rich Trott) #11559640b72e27d] - test: fix flaky test-https-agent-create-connection (Santiago Gimeno) #11649678e225d56] - test: improve https coverage to check create connection (chiaki-yokoo) #11435d4f2ef7a59] - test: apply strict mode in test-repl (Rich Trott) #115750322d3b8d5] - test: skip tests with common.skip (Sakthipriyan Vairamani (thefourtheye)) #115854575f92428] - test: move common tls connect setup into fixtures (Sam Roberts) #103894207bceacd] - test: check tls server verification with addCACert (Sam Roberts) #103891d7fab3740] - test: tls cert chain completion scenarios (Sam Roberts) #10389a1cb6992d9] - test: getgroups() may contain duplicate GIDs (Sam Roberts) #10389eb47897f52] - test: refactor test-stream2-readable-wrap.js (dpg5000) #105516f85c81f0d] - test: s/assert.equal/assert.strictEqual/ (Gibson Fahnestock) #10698afea1d041e] - test: refactor test-beforeexit-event-exit.js (cjihrig) #10577f0645200aa] - test: improve test-fs-access (Adrian Estrada) #10542f874256aae] - test: skip when openssl CLI doesn't exist (Sota Yamashita) #110959162316ef5] - test: add arrow functions to test-util-inspect (Alexey Orlenko) #11781db61c952de] - test: use eslint to fix var->const/let (Gibson Fahnestock) #10685632aee186d] - timers: fix not to close reused timer handle (Shigeki Ohtsu) #1164639f7aaa290] - timers: unlock the timers API (Rich Trott) #11580d0868ff36c] - tls: fix segfault on destroy after partial read (Ben Noordhuis) #118981baee1829b] - tls: keep track of stream that is closed (jBarz) #11776b1ddf11c14] - tls: fix macro to check NPN feature (Shigeki Ohtsu) #116556eb1c25263] - tools: ignore URLs in line length linting (Rich Trott) #11890cad425c571] - tools: update dotfile whitelist in .gitignore (Michaël Zasso) #121163858861463] - tools: add links to the stability index reference (Michael Cox) #116643e6d9922b9] - tools: remove NODE_PATH from environment for tests (Rich Trott) #11612de63698066] - tools, test: require const/let in test (Gibson Fahnestock) #1068563449972d1] - url: usehasIntlinstead oftry-catch(Daijiro Wachi) #11571