Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: testing validity of prefix in mkdtempSync #12009

Conversation

lucamaraschi
Copy link
Contributor

This test is checking for the validity of the path used as parameter
for mkdtempSync

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows [commit guidelines][]
Affected core subsystem(s)

test fs

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 23, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Mar 23, 2017
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test code LGTM, but why is test/parallel/test-mkdtemp-prefix-check.js showing up in the diff as "No changes"?

@targos
Copy link
Member

targos commented Mar 24, 2017

@cjihrig
It's a new (empty) file.

@cjihrig
Copy link
Contributor

cjihrig commented Mar 24, 2017

@targos thanks. @lucamaraschi can you remove the empty file?

This test is checking for the validity of the path used as parameter
for mkdtempSync
@lucamaraschi lucamaraschi force-pushed the test-mkdtemp-sync-prefix-check branch from a56c067 to 6da040b Compare March 24, 2017 22:57
@cjihrig
Copy link
Contributor

cjihrig commented Mar 25, 2017

@fhinkel
Copy link
Member

fhinkel commented Mar 26, 2017

Landed in c2ead7e

@fhinkel fhinkel closed this Mar 26, 2017
fhinkel pushed a commit that referenced this pull request Mar 26, 2017
This test is checking for the validity of the path used as parameter
for mkdtempSync.

PR-URL: #12009
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
This test is checking for the validity of the path used as parameter
for mkdtempSync.

PR-URL: #12009
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
This test is checking for the validity of the path used as parameter
for mkdtempSync.

PR-URL: #12009
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
This test is checking for the validity of the path used as parameter
for mkdtempSync.

PR-URL: #12009
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
This test is checking for the validity of the path used as parameter
for mkdtempSync.

PR-URL: nodejs/node#12009
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants