Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add richardlau to collaborators #12020

Merged
merged 1 commit into from
Mar 24, 2017
Merged

doc: add richardlau to collaborators #12020

merged 1 commit into from
Mar 24, 2017

Conversation

richardlau
Copy link
Member

Checklist
  • documentation is changed or added
  • commit message follows [commit guidelines][]
Affected core subsystem(s)

doc
[commit guidelines]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 24, 2017
evanlucas
evanlucas approved these changes Mar 24, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard!

@richardlau
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7019/

@bnoordhuis
Copy link
Member

For the record: I'm letting @richardlau land this without waiting for the full 48/72 hours.

@richardlau
doc: add richardlau to collaborators
cb6c0c1 
PR-URL: nodejs#12020
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@richardlau richardlau closed this Mar 24, 2017
@richardlau richardlau deleted the onboarding branch March 24, 2017 12:59
@richardlau richardlau merged commit cb6c0c1 into nodejs:master Mar 24, 2017
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 24, 2017
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@richardlau @MylesBorins
doc: add richardlau to collaborators
1f7fe55 
PR-URL: #12020
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
@MylesBorins
Copy link
Contributor

Once again, congrats!

MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@richardlau @MylesBorins
doc: add richardlau to collaborators
52511b6 
PR-URL: #12020
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@richardlau @MylesBorins
doc: add richardlau to collaborators
22af92a 
PR-URL: #12020
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@richardlau @andrew749
doc: add richardlau to collaborators
6c10654 
PR-URL: nodejs/node#12020
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@danbev danbev danbev approved these changes

@evanlucas evanlucas evanlucas approved these changes

@hiroppy hiroppy hiroppy approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@richardlau @bnoordhuis @MylesBorins @danbev @evanlucas @hiroppy @gibfahn @Trott @nodejs-github-bot